Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift Remove UA farbling on all platforms and unconditionally exclude Android model to 1.24.x #8599

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Uplift Remove UA farbling on all platforms and unconditionally exclude Android model to 1.24.x #8599

merged 1 commit into from
Apr 22, 2021

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Apr 21, 2021 •
edited by kjozwiak
Loading

Uplift of #8562
Resolves brave/brave-browser#15372
Resolves brave/brave-browser#15322
Resolves brave/brave-browser#15039
Resolves brave/brave-browser#14740

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@pilgrim-brave @yrliou
Merge pull request #8562 from brave/mpilgrim_remove_ua_farbling
6baa205 
Remove UA farbling on all platforms and unconditionally exclude Android model
@yrliou yrliou requested review from bridiver and a team as code owners April 21, 2021 21:40
@yrliou yrliou requested a review from a team April 21, 2021 21:41
@yrliou yrliou added this to the 1.24.x - Beta milestone Apr 21, 2021
@kjozwiak kjozwiak mentioned this pull request Apr 22, 2021
Closed
24 tasks
@kjozwiak
Copy link
Member

test-browser failed on Linux due to RewardsPublisherBrowserTest.VisitRegisteredPublisher as per https://ci.brave.com/job/pr-brave-browser-8562_1.24.x-linux/1/testReport/. However, this is a known intermittent issue as per brave/brave-browser#15150.

kjozwiak
kjozwiak approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.24.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8562 (comment) & #8320 (comment).

@kjozwiak kjozwiak merged commit e7d08f2 into 1.24.x Apr 22, 2021
@kjozwiak kjozwiak deleted the 8562_1.24.x branch April 22, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@yrliou @kjozwiak @pilgrim-brave