-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve import of bookmarks and settings during the onboarding process #1530
Comments
This requires a little nuanced consideration. My initial hope with this screen was to just make it truly one click and we make Brave as much like your previous browser as possible. So whatever we can import from any given competitor we would in one click. If this is not possible or requires some other much greater consideration I'm unaware of, it would be preferable to surface the import dialog right on top of this panel and when a user imports we auto advance to the next panel. I think regardless, the first option would be what we should push for in the long term. This is a quick mock of that process: @garrettr I think this might be a thing I would look to your expertise on. |
A couple of thoughts: For users auto-upgrading from browser-laptop to brave-browser, we will auto-import their browser-laptop data (#1545). For users installing brave-browser from the website, the first run experience should offer the option to import data from another browser (as shown in @rossmoody's screenshots). If you think the "one click" experience is really important, I think the most sensible UX would be to auto-detect the user's current default browser and offer to import its data as the primary option. Something similar is already partially implemented for Firefox: if Firefox is detected to be the current user's default browser, the list of browser profiles to import from is ordered such that Firefox is the first selected choice, which potentially saves the user a click. We could extend this to detect whether other browsers are the default, and order the list of choices accordingly. This would probably result in a "one-click" experience for a large fraction of users. I think it's important to keep the dropdown list of choices visible and easy to use to avoid irritating users who have more complicated setups (e.g. one browser with multiple profiles, multiple browsers used concurrently). In this case we really can't guess what the user would want and should leave the choice up to them. |
cc: @clifton thoughts after having gone through #1548? |
This should be a fairly easy win, but we'd need to try a proof of concept first 😄When quickly trying it, I didn't see a way to pop up the modal shown above. We could expose the content of the model in our wizard instead (providing a better experience). ex: have a dropdown with:
Will get back to you after trying this out |
Tracked with brave/brave-browser#1530 Code is rough, but this does work (ex: you can pick an option and import will happen)
Verification passed on
Verified test plan from brave/brave-ui#504 |
@rebron @bsclifton - just to confirm, when importing from brave://welcome, is the expectation that any item checked by default on brave://settings/importData will be imported when importing from welcome? So if you were to import Chrome from brave://settings/importData cookies, history, etc are checked and imported unless unchecked. So, if you import Chrome from brave://welcome, will you also import cookies, history, etc? |
@LaurenWags Yes. Any items that would normally be checked by default (as seen by skipping this step and doing the manual import from settings), should be imported over. There shouldn't be an "unless checked" by users scenario. Unchecking items from the manual import bookmarks/settings screen shouldn't affect this screen since this is a one way new user/new profile flow. |
Verification passed on
|
Description
Add import bookmarks/settings to new welcome flow. Invoke something similar to: brave://settings/importData
but need to keep users in the flow after import and not taken to separate page.
Design
The text was updated successfully, but these errors were encountered: