Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

✨New welcome flow for importing settings from other browsers #504

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

imptrx
Copy link
Contributor

@imptrx imptrx commented Jun 24, 2019

Issue tracker: brave/brave-browser#1530
Spec: brave/brave-core#2679 (comment)

Changes

  • Inline import option in the welcome flow for importing settings from other browsers
  • Dev Concern: I copied the Select into "features/welcome" since we have multiple "screens" in welcome relying on it - it didn't make sense to have all of them cross-referencing a shields component (I am assuming we can lift it to a general directory when we migrate our stories to core)
  • Quick view:
    welcome-import

Test plan

  • brave://welcome should still load properly when loaded
  • Should be an inline option to pick a browser to import settings from via drop down
  • "Import" button is disabled unless an valid option is chosen
  • Import button should lead to next step of on-boarding process
Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@imptrx imptrx self-assigned this Jun 24, 2019
@imptrx
Copy link
Contributor Author

imptrx commented Jun 24, 2019

Should be no breaking changes in brave-core as it's mostly storybook changes plus duplication of a component 🙈

@bsclifton
Copy link
Member

This is amazing 😄 Doesn't look like it would be too hard to integrate into brave/brave-core#2679 after this is done

Copy link
Contributor

@rossmoody rossmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants