Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tab search button has weird hover/press effect #15670

Closed
simonhong opened this issue May 7, 2021 · 1 comment · Fixed by brave/brave-core#8741
Closed

tab search button has weird hover/press effect #15670

simonhong opened this issue May 7, 2021 · 1 comment · Fixed by brave/brave-core#8741
Assignees
@simonhong
Labels
OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.25.x - Release

Comments

@simonhong
Copy link
Member

image
@simonhong simonhong self-assigned this May 7, 2021
simonhong added a commit to brave/brave-core that referenced this issue May 7, 2021
@simonhong
Fixed TabSearchButton's weird hover/pressed effect
9fc72b5 
fix brave/brave-browser#15670

TabSearchButton needs original radius value from LayoutProvider.
However, we override it with BraveLayoutProvider. So, implemented in GetCornerRadius()
in subclass to give origin value.
@simonhong simonhong mentioned this issue May 7, 2021
Merged
24 tasks
@mkarolin mkarolin mentioned this issue May 7, 2021
Merged
24 tasks
@simonhong simonhong added this to the 1.26.x - Nightly milestone May 7, 2021
@stephendonner
Copy link

Verified FIXED using

Brave 1.26.18 Chromium: 91.0.4472.38 (Official Build) nightly (64-bit)
Revision 8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS Windows 10 OS Version 2009 (Build 21376.1)

Confirmed that on hover, in both light and dark-color modes, the hover effect is without the extra glyph/circle.

light dark
tab-hover-light tab-hover-dark

@stephendonner stephendonner mentioned this issue May 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed TabSearchButton's weird hover/pressed effect brave/brave-core
3 participants
@stephendonner @kjozwiak @simonhong