Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cr91: Disable Fledge Interest Group features #15847

Closed
mkarolin opened this issue May 14, 2021 · 0 comments · Fixed by brave/brave-core#8039
Closed

Cr91: Disable Fledge Interest Group features #15847

mkarolin opened this issue May 14, 2021 · 0 comments · Fixed by brave/brave-core#8039
Assignees
@mkarolin
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop privacy QA/No release-notes/exclude
Milestone
1.25.x - Release

Comments

@mkarolin
Copy link
Contributor

Per @pes10k we should disable kFledgeInterestGroups and kFledgeInterestGroupAPI

Upstream change:
https://source.chromium.org/chromium/chromium/src/+/b8318938b38a2146ab8e34fbf57a4b00999151e9

MERGE: Split the Fledge feature flag into a global guard flag and an exposure flag.

The current configuration uses the FledgeInterestGroups feature as both a global guard for the feature as well as a control for an origin trial. Ideally we want to be able to disable most of the code related to the feature. Since that cannot be done at runtime on a case by case basis we can't use a runtime flag for that.

This change uses the previous flag as a global on/off switch, while adding a separate feature flag to control a possible future origin trial.
@mkarolin mkarolin added privacy QA/No release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop labels May 14, 2021
mkarolin added a commit to brave/brave-core that referenced this issue May 14, 2021
@mkarolin
Disables Fledge Interest Groups.
22882a7 
Feature and origin trial.

Fixes brave/brave-browser#15847
@mkarolin mkarolin mentioned this issue May 14, 2021
Merged
23 tasks
mkarolin added a commit to brave/brave-core that referenced this issue May 18, 2021
@mkarolin
Disables Fledge Interest Groups.
5acfba9 
Feature and origin trial.

Fixes brave/brave-browser#15847
@mkarolin mkarolin self-assigned this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop privacy QA/No release-notes/exclude
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

Disables TrustTokens feature. brave/brave-core
1 participant
@mkarolin