Disables TrustTokens feature. #8039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pes10k
approved these changes
Apr 27, 2021
mkarolin
force-pushed
the
maxk-disable-trust-tokens
branch
2 times, most recently
from
5f2af2b
to
3f462ef
Compare
bridiver
approved these changes
May 18, 2021
|
CI failures:
|
Also, disables the origin trial. Fixes brave/brave-browser#13886
Features and also the origin trial. Fixes brave/brave-browser#15848
Feature and origin trial. Fixes brave/brave-browser#15847
We need to follow up on this to proxy component download and also fiture out API keys maybe as it currently doesn't work. Chromium change: https://source.chromium.org/chromium/chromium/src/+/9b46507cf5a5ee1460dc9c20307206d7cb004a2f commit 9b46507cf5a5ee1460dc9c20307206d7cb004a2f Author: evliu <evliu@google.com> Date: Fri Mar 5 00:49:23 2021 +0000 Enable the Live Caption feature by default This CL enables the LiveCaption, UseSodaForLiveCaption, and IPH_LiveCaption features by default. Bug: 1182008
mkarolin
force-pushed
the
maxk-disable-trust-tokens
branch
from
3f462ef
to
58b5841
Compare
|
Rebased due to a conflict and merged. |
mkarolin
added a commit
that referenced
this pull request
May 18, 2021
Disables TrustTokens feature.
sangwoo108
added a commit
that referenced
this pull request
Feb 9, 2023
[We disabled the "Trust token" feature](#8039), so we shouldn't reveal this item.
25 tasks
sangwoo108
added a commit
that referenced
this pull request
Mar 28, 2023
[We disabled the "Trust token" feature](#8039), so we shouldn't reveal this item.
sangwoo108
added a commit
that referenced
this pull request
Mar 30, 2023
* Hide "Trust Token" item from devtools [We disabled the "Trust token" feature](#8039), so we shouldn't reveal this item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#13886
Fixes brave/brave-browser#15847
Fixes brave/brave-browser#15848
Fixes brave/brave-browser#15902
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: