Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable TrustTokens API #13886

Closed
pes10k opened this issue Feb 2, 2021 · 0 comments · Fixed by brave/brave-core#8039
Closed

Disable TrustTokens API #13886

pes10k opened this issue Feb 2, 2021 · 0 comments · Fixed by brave/brave-core#8039
Assignees
@mkarolin
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium. privacy QA/No release-notes/exclude
Milestone
1.25.x - Release

Comments

@pes10k
Copy link
Contributor

pes10k commented Feb 2, 2021

Currently TrustTokens are in an origin trial in chrome. They have well known privacy concerns (some of which are listed in the spec's explainer). We should disable them in Brave until both
i) we're more confident / sure that the privacy issues have been addressed (ie more vetting on our end) and
ii) we're confident there is a benefit to Brave users for having them installed
@pes10k pes10k added OS/Android Fixes related to Android browser functionality OS/Desktop privacy privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium. labels Feb 2, 2021
@pes10k pes10k added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 2, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Feb 12, 2021
@mkarolin
Disables TrustTokens feature.
522fc78 
Also, disables the feature in blink and origin trials.

Fixes brave/brave-browser#13886
mkarolin added a commit to brave/brave-core that referenced this issue Feb 22, 2021
@mkarolin
Disables TrustTokens feature.
305f59d 
Also, disables the origin trial.

Fixes brave/brave-browser#13886
@mkarolin mkarolin mentioned this issue Feb 22, 2021
Merged
23 tasks
mkarolin added a commit to brave/brave-core that referenced this issue May 14, 2021
@mkarolin
Disables TrustTokens feature.
271afbe 
Also, disables the origin trial.

Fixes brave/brave-browser#13886
@mkarolin mkarolin mentioned this issue May 18, 2021
Merged
24 tasks
mkarolin added a commit to brave/brave-core that referenced this issue May 18, 2021
@mkarolin
Disables TrustTokens feature.
383d187 
Also, disables the origin trial.

Fixes brave/brave-browser#13886
@mkarolin mkarolin added this to the 1.26.x - Nightly milestone May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium. privacy QA/No release-notes/exclude
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

Disables TrustTokens feature. brave/brave-core
3 participants
@pes10k @kjozwiak @mkarolin