-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contextual reload icon on Brave Rewards panel should be removed #1598
Comments
@srirambv this is an indicator that is recurring donation. We use same icon in tips table in settings page |
@NejcZdovc to be honest its not very intuitive as to what the indicator is about. Using the reload button there, my initial thought was to refresh to see the donation. We should may be add a tool tip to explain what that is. On the rewards panel the text is self explanatory that the donation is to be done monthly so there is no need for the icon. If we do need an icon there and on the tips table in settings page may be we should use something like this rather than the reload button icon |
cc @jenn-rhim |
+1 to @srirambv comment - I also thought it was a reload button. It's almost identical to the browser reload icon: I don't think we need an icon, but if we do one that's more similar to the icon from #1598 (comment) seems more appropriate to me. |
This was going to be removed. Just didn't make the issue list yet. @NejcZdovc please remove it in all instances and if necessary, we will create a new icon later. |
sure we can do that |
Adding from #1620 which was closed in favour of this. When QAing, we'll need to make sure that the following scenario as been addressed as well.
|
was closed by brave-ui, we still need to bump ui version and update it in core |
Removes reload icon Resolves brave/brave-browser#1935 Resolves brave/brave-browser#1598
Verification passed on
Verification passed on
Verified passed with
|
Description
Donate to this site monthly has a reload button next to it in rewards panel that is not functional. Should be removed similar to help icon removed in #1472
Steps to Reproduce
Actual result:
Expected result:
Icon should be reomved
Reproduces how often:
All the time
Brave version (chrome://version info)
Reproducible on current release:
Yes
No
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: