Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subtitle text string to Add Funds dialog #1935

Closed
bradleyrichter opened this issue Oct 31, 2018 · 2 comments · Fixed by brave/brave-core#798
Closed

Add subtitle text string to Add Funds dialog #1935

bradleyrichter opened this issue Oct 31, 2018 · 2 comments · Fixed by brave/brave-core#798
Assignees
@NejcZdovc
Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.58.x - Release ...

Comments

@bradleyrichter
Copy link

To make the add funds window a bit easier to understand, we need to add more helpful intro text.

image

Initial strings:

Title: Send cryptocurrency from your external account to your Brave Rewards wallet.

Subhead: Be sure to use the address below that matches the type of cryto you own. It will be converted automatically to BAT by Uphold and appear as an increased balance in your Brave Rewards wallet. Please allow up to one hour for your wallet balance to update.
@NejcZdovc NejcZdovc added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Oct 31, 2018
@NejcZdovc NejcZdovc mentioned this issue Nov 4, 2018
Merged
@NejcZdovc NejcZdovc added this to the 0.59.x - Nightly milestone Nov 4, 2018
@NejcZdovc NejcZdovc mentioned this issue Nov 4, 2018
Merged
18 tasks
@NejcZdovc NejcZdovc added the QA/No label Nov 4, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 4, 2018
@NejcZdovc
Updates text for add funds dialog
5985435 
Removes reload icon

Resolves brave/brave-browser#1935
Resolves brave/brave-browser#1598
@LaurenWags LaurenWags added QA/Yes and removed QA/No labels Dec 11, 2018
@bradleyrichter
Copy link
Author

typo - "cryto" should be "crypto"

@LaurenWags
Copy link
Member

LaurenWags commented Dec 12, 2018 •
edited by srirambv
Loading

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Verification passed on

Brave 0.59.6 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows

Verification passed on

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

image

@kjozwiak kjozwiak mentioned this issue Dec 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Updates text for add funds dialog brave/brave-core
6 participants
@kjozwiak @NejcZdovc @bradleyrichter @srirambv @LaurenWags @GeetaSarvadnya