Show "Added to sidebar" feedback bubble only three times #16018

simonhong · 2021-05-21T06:27:27Z

Currently, that feedback bubble is shown everytime new items are added.
Limit three times.

fix brave/brave-browser#16018 We will show item added feedback bubble only three times.

stephendonner · 2021-05-27T23:58:53Z

Verified PASSED using the testplan from brave/brave-core#8911 with build

Brave	1.27.25 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision	1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS	macOS Version 11.4 (Build 20F71)

Steps:

Launched Brave with clean profile and enabled sidebar via brave://flags; relaunched
Loaded brave.com
Added current tab's site to sidebar
Repeated steps 2 and 3 (with google.com, mozilla.com, and apple.com) and checked that the sidebar-item-added feedback bubble is displayed only three times - as I added apple.com it didn't display.

brave://flags	brave.com	google.com	mozilla.com	apple.com

simonhong added the OS/Desktop label May 21, 2021

simonhong self-assigned this May 21, 2021

simonhong added QA/Yes feature/sidebar Relating to Brave's Sidebar feature release-notes/exclude labels May 21, 2021

simonhong mentioned this issue May 21, 2021

Work required before we can release Sidebar #14980

Closed

28 tasks

simonhong changed the title ~~Show "Added to sidebar" tooltip only three times~~ Show "Added to sidebar" feedback bubble only three times May 24, 2021

simonhong added a commit to brave/brave-core that referenced this issue May 24, 2021

Limit show sidebar item added feedback bubble display count

5dffb9c

fix brave/brave-browser#16018 We will show item added feedback bubble only three times.