Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit show sidebar item added feedback bubble display count #8911

Merged
merged 1 commit into from
May 24, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented May 24, 2021

fix brave/brave-browser#16018

We will show item added feedback bubble only three times.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch browser with clean profile and turn on sidebar feature flags and relaunch
  2. Visit any site
  3. Add current tab's site to sidebar
  4. Repeat above 2 and 3 step and check sidebar item added feedback bubble is displayed only three times.

fix brave/brave-browser#16018

We will show item added feedback bubble only three times.
@simonhong simonhong self-assigned this May 24, 2021
@simonhong simonhong requested a review from emerick May 24, 2021 08:15
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit cb1191c into master May 24, 2021
@simonhong simonhong deleted the limit_sidebar_item_added_shown_count branch May 24, 2021 23:47
@simonhong simonhong added this to the 1.27.x - Nightly milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show "Added to sidebar" feedback bubble only three times
2 participants