Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom ad notifications do not respect dark mode on Linux #16234

Closed
btlechowski opened this issue Jun 3, 2021 · 1 comment · Fixed by brave/brave-core#9337
Closed

Custom ad notifications do not respect dark mode on Linux #16234

btlechowski opened this issue Jun 3, 2021 · 1 comment · Fixed by brave/brave-core#9337
Assignees
@aseren
Labels
bug feature/ads OS/Desktop OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.28.x - Release

Comments

@btlechowski
Copy link

Follow up to #14810

Steps to Reproduce

  1. Run Brave in Dark mode
  2. Trigger a custom ad

Actual result:

Custom ad does not respect dark mode
Custom ad is shown in light colors
image

Expected result:

Custom ad is shown in light colors

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.26.50 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Ubuntu 18.04 LTS

cc @tmancey @moritzhaller @jsecretan @rebron @brave/legacy_qa
@btlechowski btlechowski mentioned this issue Jun 3, 2021
Closed
@tmancey tmancey changed the title Custom ads notification does not respect dark mode on Linux Custom ad notifications do not respect dark mode on Linux Jun 10, 2021
@tmancey tmancey added bug priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude and removed OS/Desktop labels Jun 10, 2021
@btlechowski btlechowski mentioned this issue Jun 11, 2021
Closed
@aseren aseren self-assigned this Jul 2, 2021
@aseren aseren mentioned this issue Jul 5, 2021
Merged
24 tasks
aseren added a commit to brave/brave-core that referenced this issue Jul 6, 2021
@aseren
Made custom ads popup respects light/dark mode on linux.
4d6648e 
Browser on linux uses system theme if no parent/context is set for widget
on creation. So instead of getting theme through GetNativeTheme() method
use GetActiveBraveDarkModeType().
fix brave/brave-browser#16234
@tmancey tmancey added this to the 1.28.x - Nightly milestone Jul 7, 2021
@btlechowski btlechowski mentioned this issue Jul 13, 2021
Closed
@btlechowski
Copy link
Author

Verification passed on

Brave 1.28.76 Chromium: 92.0.4515.93 (Official Build) nightly (64-bit)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS Ubuntu 18.04 LTS

Verified test plan from the description
image
image

Notification does not change the color dynamically with the browser. Logged #16933
Example:
image

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
bug feature/ads OS/Desktop OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.28.x - Release
Development

Successfully merging a pull request may close this issue.

Made custom ads popup respects light/dark mode on linux. brave/brave-core
5 participants
@tmancey @bsclifton @LaurenWags @btlechowski @aseren