Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Ad Notification does not change the color dynamically with the browser #16933

Closed
btlechowski opened this issue Jul 13, 2021 · 1 comment · Fixed by brave/brave-core#9430
Closed

Custom Ad Notification does not change the color dynamically with the browser #16933

btlechowski opened this issue Jul 13, 2021 · 1 comment · Fixed by brave/brave-core#9430
Assignees
@aseren
Labels
bug feature/ads OS/Desktop QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.29.x - Release

Comments

@btlechowski
Copy link

Follow up to #16234

Steps to Reproduce

  1. Run Brave in Dark mode
  2. Open brave://settings/appearance
  3. Trigger a custom ad
  4. While the ad is shown: Change Brave colors to Light

Note: subsequent ads will have proper color.

Actual result:

Custom Ad Notification does not change the color dynamically with the browser
image

Expected result:

Custom Ad Notification does change the color dynamically with the browser

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.28.76 Chromium: 92.0.4515.93 (Official Build) nightly (64-bit)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS Ubuntu 18.04 LTS

cc @tmancey @moritzhaller @jsecretan @rebron @brave/legacy_qa @aseren
@btlechowski btlechowski mentioned this issue Jul 13, 2021
Closed
@aseren aseren mentioned this issue Jul 14, 2021
Merged
24 tasks
aseren added a commit to brave/brave-core that referenced this issue Jul 14, 2021
@aseren
Fix dynamic theme change custom ad notification popup.
ee02e0d 
The PR overrides GetNativeTheme() for ad notification popup widget to
force getting the browser theme instead of getting system theme for linux.
fix brave/brave-browser#16933
aseren added a commit to brave/brave-core that referenced this issue Jul 18, 2021
@aseren
Fix dynamic theme change custom ad notification popup.
7814306 
The PR overrides GetNativeTheme() for ad notification popup widget to
force getting the browser theme instead of getting system theme for linux.
fix brave/brave-browser#16933
aseren added a commit to brave/brave-core that referenced this issue Jul 20, 2021
@aseren
Fix dynamic theme change custom ad notification popup.
f77c058 
The PR overrides GetNativeTheme() for ad notification popup widget to
force getting the browser theme instead of getting system theme for linux.
fix brave/brave-browser#16933
@tmancey tmancey added this to the 1.29.x - Nightly milestone Jul 21, 2021
@btlechowski
Copy link
Author

Great work @aseren !

Verification passed on

Brave 1.29.23 Chromium: 92.0.4515.107 (Official Build) nightly (64-bit)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Upon changing the theme color, custom ad notification color is immediately changed
image
image

After browser restart color is retained
image

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
bug feature/ads OS/Desktop QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.29.x - Release
Development

Successfully merging a pull request may close this issue.

Fix dynamic theme change custom ad notification popup. brave/brave-core
3 participants
@tmancey @btlechowski @aseren