Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verified icon not appearing for verified YT channels #1795

Closed
kjozwiak opened this issue Oct 23, 2018 · 1 comment · Fixed by brave/brave-core#713
Closed

verified icon not appearing for verified YT channels #1795

kjozwiak opened this issue Oct 23, 2018 · 1 comment · Fixed by brave/brave-core#713

Comments

@kjozwiak
Copy link
Member

Description

Verification icons not appearing for verified YT channels: Examples:

["youtube#channel:UClFSU9_bUb4Rc6OYfTt5SPw",true,false,{}] <-- Philip DeFranco
["youtube#channel:UCazMm3tOCkYrIGE_17j0mVg",true,false,{}] <-- Bart Barker

Both of the above channels are verified but don't have the verified icons displayed:

screen shot 2018-10-23 at 2 20 01 am

Steps to Reproduce

  1. launch 0.55.20 Chromium: 70.0.3538.67 and enable rewards
  2. visit https://www.youtube.com/channel/UCazMm3tOCkYrIGE_17j0mVg and watch a video
  3. visit https://www.youtube.com/channel/UClFSU9_bUb4Rc6OYfTt5SPw and watch a video
  4. visit brave://rewards and you'll notice both entires are not displaying the verified icon

Actual result:

Verified YT channels are not displaying the verified icons

Expected result:

Verified YT channels should be displaying verified icons

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Yes, reproducible under dev & beta.

Additional Information

CCing @jenn-rhim

@kjozwiak kjozwiak added this to the 0.55.x - Release Hotfix 2 milestone Oct 23, 2018
@NejcZdovc NejcZdovc self-assigned this Oct 23, 2018
@NejcZdovc NejcZdovc changed the title favicons not appearing for verified YT channels verified icon not appearing for verified YT channels Oct 23, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 23, 2018
@kjozwiak
Copy link
Member Author

kjozwiak commented Oct 26, 2018

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

screen shot 2018-10-26 at 11 03 45 am

Verification Passed on

Brave 0.55.21 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

image

Verification Passed on

Brave 0.55.21 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment