Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dark theme for dev-channel #184

Closed
Sa-Ja-Di opened this issue May 7, 2018 · 4 comments
Closed

Add a dark theme for dev-channel #184

Sa-Ja-Di opened this issue May 7, 2018 · 4 comments

Comments

@Sa-Ja-Di
Copy link

Sa-Ja-Di commented May 7, 2018

As there are also many people around with some eye issues, a dark UI would help such people quite a lot.

That suggestion was also made on the Brave old repository, perhaps this idea can built inside the newly planned Brave, based on real Chromium?

@bsclifton bsclifton added the feature/user-interface All UI related label May 18, 2018
@bbondy bbondy added this to the Backlog milestone Jun 6, 2018
@kekukui
Copy link

kekukui commented Aug 5, 2018

Developers, please reference the following comment which offers a potential solution:

brave/browser-laptop#271 (comment)

@bbondy bbondy changed the title Suggestion: Black browser theme Add a dark theme for dev-channel Aug 14, 2018
bbondy added a commit to brave/brave-core that referenced this issue Aug 15, 2018
@bbondy bbondy modified the milestones: Backlog, Releasable builds 0.55.x Aug 16, 2018
@bbondy bbondy self-assigned this Aug 16, 2018
@bbondy bbondy added the QA/Yes label Aug 17, 2018
@Jacalz
Copy link
Contributor

Jacalz commented Aug 18, 2018

How do you switch back to the light theme? It just switched to dark theme when i updated and I couldn't find any option to change to light... cc @bbondy

@bbondy
Copy link
Member

bbondy commented Aug 18, 2018

Option will be added but that's the default for dev channel only.

@btlechowski
Copy link

btlechowski commented Sep 21, 2018

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verified passed with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants