Updates to welcome flow to fix multiple issues

[rossmoody]

Test Cases

• ensure that the strings/screen match Updates to welcome flow to fix multiple issues #1847 (comment)
• ensure that the animation works when brave://welcome is initially loaded
• ensure that skip welcome tour works on all six pages and converts brave://welcome into about:newtab
• ensure that clicking on the "dots" take you to the correct page
• ensure that Lets Go -> takes you to the Import bookmarks & settings page
• ensure that clicking on Import opens brave://settings/importData in a new tab
• ensure that clicking on Settings opens brave://settings/search
• ensure that clicking on Choose your theme opens brave://settings/appearance
• ensure that clicking on Enable Reward opens brave://rewards/
• ensure that clicking on Done converts brave://welcome into about:newtab

Original Issue

Description

The new welcome experience in Brave-UI needs merged. It is currently living in https://github.com/brave/brave-ui/tree/1.0

A living representation of the branch can be viewed here: https://bit.ly/2ApyaXiw

[rebron]

this fix should also address:
#1316 (comment)

[LaurenWags]

@rossmoody @cezaraugusto could one of you provide a test plan for this issue?

[srirambv]

@rossmoody I see the flow https://bit.ly/2ApyaXi on the latest beta. Is this the expected flow or are there any other iterations of this?

[rossmoody]

We have outstanding issues to get the Welcome experience up to spec but for the time being the Welcome Experience is reflecting the right flow.

[kjozwiak]

@rossmoody the current strings under brave://welcome differ in some places compared to the flow that's outlined in https://bit.ly/2ApyaXi. Can you quickly confirm that these are the expected screens for 0.59.28 Chromium: 72.0.3626.64?

[rossmoody]

@bradleyrichter and I tackled the locale and PR'd directly against Core (we were hoping to make the Muon migration). The screenshots you posted here are the most current/approved/correct and I will circle back to Brave UI so there's parity. There will be updates to the copy once we find time to bring the inline functionality into the panels but for now this is good. Sry for making your jobs hard here. @kjozwiak @LaurenWags

[kjozwiak]

@rossmoody no worries! QA will go through the current brave://welcome implementation and make sure that they match the screenshots I added above. We'll make sure that that all the buttons function as expected. It sounds like we won't be doing any other changes in 0.59.x as we're releasing next week. If we do anymore changes, can you make sure we get an issue filed?

[kjozwiak]

@rossmoody added a test plan in the original comment. Please let me know if there's anything missing.

[kjozwiak]

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave	0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision	eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS	Mac OS X

• went through the test cases outlined in Updates to welcome flow to fix multiple issues #1847 (comment)

Verification passed on Brave	0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision	eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS	Linux

• Verified steps from Updates to welcome flow to fix multiple issues #1847 (comment)
• Logged a follow up issue for Linux specific text string issue (& shown on onboarding first screen #3068)
• Logged a follow up issue for onboarding behaviour when settings pages are opened (Onboarding doesn't auto navigate to the next step when going back to brave://welcome screen #3069)

Verification passed on

Brave	0.59.28 Chromium: 72.0.3626.64 (Official Build) beta (64-bit)
Revision	eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS	Windows 10

• went through the test cases outlined in Updates to welcome flow to fix multiple issues #1847 (comment)