Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to welcome flow to fix multiple issues #1847

Closed
rossmoody opened this issue Oct 25, 2018 · 9 comments · Fixed by brave/brave-core#894
Closed

Updates to welcome flow to fix multiple issues #1847

rossmoody opened this issue Oct 25, 2018 · 9 comments · Fixed by brave/brave-core#894

Comments

@rossmoody
Copy link
Contributor

rossmoody commented Oct 25, 2018

Test Cases

  • ensure that the strings/screen match Updates to welcome flow to fix multiple issues #1847 (comment)
  • ensure that the animation works when brave://welcome is initially loaded
  • ensure that skip welcome tour works on all six pages and converts brave://welcome into about:newtab
  • ensure that clicking on the "dots" take you to the correct page
  • ensure that Lets Go -> takes you to the Import bookmarks & settings page
  • ensure that clicking on Import opens brave://settings/importData in a new tab
  • ensure that clicking on Settings opens brave://settings/search
  • ensure that clicking on Choose your theme opens brave://settings/appearance
  • ensure that clicking on Enable Reward opens brave://rewards/
  • ensure that clicking on Done converts brave://welcome into about:newtab

Original Issue

Description

The new welcome experience in Brave-UI needs merged. It is currently living in https://github.com/brave/brave-ui/tree/1.0

A living representation of the branch can be viewed here: https://bit.ly/2ApyaXiw

@rebron rebron changed the title New welcome flow updates to welcome flow to fix multiple issues Oct 25, 2018
@rebron rebron added this to the 0.56.x - Beta milestone Oct 25, 2018
@rebron
Copy link
Collaborator

rebron commented Oct 25, 2018

this fix should also address:
#1316 (comment)

@rebron rebron removed their assignment Oct 26, 2018
@rebron rebron added the l10n label Oct 29, 2018
@rebron rebron removed this from the 0.56.x - Beta milestone Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 30, 2018
@petemill petemill modified the milestones: 1.x Backlog, 0.60.x - Dev Dec 12, 2018
@bbondy bbondy changed the title updates to welcome flow to fix multiple issues Updates to welcome flow to fix multiple issues Dec 20, 2018
@bbondy bbondy added the QA/Yes label Dec 20, 2018
@LaurenWags
Copy link
Member

@rossmoody @cezaraugusto could one of you provide a test plan for this issue?

@srirambv
Copy link
Contributor

srirambv commented Jan 2, 2019

@rossmoody I see the flow https://bit.ly/2ApyaXi on the latest beta. Is this the expected flow or are there any other iterations of this?

@rossmoody
Copy link
Contributor Author

We have outstanding issues to get the Welcome experience up to spec but for the time being the Welcome Experience is reflecting the right flow.

@kjozwiak
Copy link
Member

@rossmoody the current strings under brave://welcome differ in some places compared to the flow that's outlined in https://bit.ly/2ApyaXi. Can you quickly confirm that these are the expected screens for 0.59.28 Chromium: 72.0.3626.64?

screen shot 2019-01-23 at 6 03 56 pm

screen shot 2019-01-23 at 6 04 01 pm

screen shot 2019-01-23 at 6 04 06 pm

screen shot 2019-01-23 at 6 04 12 pm

screen shot 2019-01-23 at 6 04 18 pm

screen shot 2019-01-23 at 6 04 25 pm

@rossmoody
Copy link
Contributor Author

@bradleyrichter and I tackled the locale and PR'd directly against Core (we were hoping to make the Muon migration). The screenshots you posted here are the most current/approved/correct and I will circle back to Brave UI so there's parity. There will be updates to the copy once we find time to bring the inline functionality into the panels but for now this is good. Sry for making your jobs hard here. @kjozwiak @LaurenWags

@kjozwiak
Copy link
Member

@rossmoody no worries! QA will go through the current brave://welcome implementation and make sure that they match the screenshots I added above. We'll make sure that that all the buttons function as expected. It sounds like we won't be doing any other changes in 0.59.x as we're releasing next week. If we do anymore changes, can you make sure we get an issue filed?

@kjozwiak
Copy link
Member

@rossmoody added a test plan in the original comment. Please let me know if there's anything missing.

@kjozwiak
Copy link
Member

kjozwiak commented Jan 24, 2019

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X
Verification passed on Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Linux

Verification passed on

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta (64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment