Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is out of bounds on adaptive captcha max attempts reached modal for translations #18971

Closed
btlechowski opened this issue Oct 25, 2021 · 6 comments · Fixed by brave/brave-core#12741

Comments

@btlechowski
Copy link

Follow up to #15600

Steps to Reproduce

  1. Clean profile
  2. Run Brave in Polish PL locale
  3. Enable Rewards and Ads
  4. Schedule a captcha for your payment ID
  5. Trigger unblinded tokens refill
  6. Click Rozwiąż
  7. Fail captcha till you get max attempts reached modal

Actual result:

Text is out of bounds
image
image

Expected result:

Text is within bounds

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.32.76 Chromium: 95.0.4638.54 (Official Build) beta (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Ubuntu 18.04 LTS

cc @emerick @tmancey @jsecretan @brave/legacy_qa @rebron @mkarolin

@emerick
Copy link
Contributor

emerick commented Oct 25, 2021

I don't think we can make that button any wider. Maybe this should just be text with a link instead.

@emerick
Copy link
Contributor

emerick commented Oct 27, 2021

See if we can reword the button to use shorter text.

@emerick emerick added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 27, 2021
@emerick
Copy link
Contributor

emerick commented Oct 27, 2021

@rebron @Miyayes The text in English is "Contact support". Would you suggest changing that to "Contact" in order to shorten it? Or other thoughts?

Text above the button says: "'Looks like this is not working, Brave ads will remain paused. Contact us if you need help with the captcha."

@mkarolin
Copy link
Contributor

I think we can probably shorten the text a bit. Would just saying Skontaktuj się z pomocą techniczną be an acceptable replacement @btlechowski? It seems the current translation actually is saying something like "contact technical support department!" (there's no ! in the original either 😄 ).

Additionally, we can probably make the button grow with the text. It's not pretty but it's better than the text sticking out. Something like:

image

image

@btlechowski
Copy link
Author

btlechowski commented Mar 24, 2022

@mkarolin Skontaktuj się z pomocą techniczną should work great! Thanks!

mkarolin added a commit to brave/brave-core that referenced this issue Mar 24, 2022
Fixes brave/brave-browser#18971

Changed:
 * the button to grow vertically with the text
 * the header to align with the sad face image when the text exceeds 1
   line
 * the sad face image to center vertically with the header.

The localization change has been made in Transifex, but is also being
applied here preemptively.
@mkarolin mkarolin added this to the 1.39.x - Nightly milestone Mar 25, 2022
@btlechowski
Copy link
Author

Verification passed on

Brave 1.39.87 Chromium: 101.0.4951.41 (Official Build) beta (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants