Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rewards] Modified adaptive captcha error message style. #12741

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#18971

Changed:

  • the button to grow vertically with the text
  • the header to align with the sad face image when the text exceeds 1 line
  • the sad face image to center vertically with the header.

The localization change has been made in Transifex, but is also being
applied here preemptively.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Fixes brave/brave-browser#18971

Changed:
 * the button to grow vertically with the text
 * the header to align with the sad face image when the text exceeds 1
   line
 * the sad face image to center vertically with the header.

The localization change has been made in Transifex, but is also being
applied here preemptively.
@mkarolin mkarolin requested a review from a team as a code owner March 24, 2022 20:56
@mkarolin mkarolin self-assigned this Mar 24, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 24, 2022
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin
Copy link
Collaborator Author

CI Linux: upstream unit/browser tests failed because the branch hasn't been rebased to include the commit with the right filters.
This change doesn't affect anything upstream related.

@mkarolin mkarolin merged commit b72b6ee into master Mar 25, 2022
@mkarolin mkarolin deleted the maxk-fix-captcha-error branch March 25, 2022 16:07
@mkarolin mkarolin added this to the 1.39.x - Nightly milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text is out of bounds on adaptive captcha max attempts reached modal for translations
4 participants