Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor contribution flow #1987

Closed
NejcZdovc opened this issue Nov 5, 2018 · 0 comments · Fixed by brave/brave-core#806
Closed

Refactor contribution flow #1987

NejcZdovc opened this issue Nov 5, 2018 · 0 comments · Fixed by brave/brave-core#806
Assignees
@NejcZdovc
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude
Milestone
0.57.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Nov 5, 2018 •
edited
Loading

Part 2 of refactors for retries

We need to split logic for contribution into separate class in native ledger, so that we can easily implement retry logic
@NejcZdovc NejcZdovc added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Nov 5, 2018
@NejcZdovc NejcZdovc self-assigned this Nov 5, 2018
@NejcZdovc NejcZdovc mentioned this issue Nov 5, 2018
Closed
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 5, 2018
@NejcZdovc
Splits contribution into seperate file for better organization
7fb0938 
Resolves brave/brave-browser#1987
@NejcZdovc NejcZdovc mentioned this issue Nov 5, 2018
Merged
18 tasks
@NejcZdovc NejcZdovc added the QA/No label Nov 5, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 8, 2018
@NejcZdovc
Splits contribution into seperate file for better organization
32930d2 
Resolves brave/brave-browser#1987
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.58.x - Dev Nov 8, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.58.x - Dev, 0.57.x - Beta Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude
Projects
None yet
Milestone
0.57.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Splits contribution into separate file for better organisation brave/brave-core
2 participants
@bbondy @NejcZdovc