Add retries to contribution

[NejcZdovc]

We need to handle all error paths and do retries when necessary.

We will have two refactors prior to that

• Split state: Move state into separate class in native ledger #1997
• Split contribution Refactor contribution flow #1987

[NejcZdovc]

@mandar-brave do we have spec for this flows? I know that we wanted to do it, but not sure if we ever did

[mandar-brave]

Hey @nejc Zdovc <nejc@brave.com> - see the link at the bottom of David's BR spec - it links to an excel. This was discussed separately as a state system and is in its own tab. Alternatively, i can add all failure/transitional state changes in the spec. R, Mandar

…

On Wed, Oct 10, 2018 at 3:35 AM Nejc Zdovc ***@***.***> wrote: @mandar-brave <https://github.com/mandar-brave> do we have spec for this flows? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1483 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AiRIkzgl6zzXIBtbJZMuvK8ZFQm4zeTZks5ujc15gaJpZM4XVDPk> .

-- Best, Mandar

[mandar-brave]

@NejcZdovc we have an existing spec.
However, @mrose17 is suggesting that he will be working with you and @evq for replicating retry logic from existing Muon client.

@mrose17 please assign to yourself if necessary.

[mandar-brave]

@NejcZdovc moving priority to P1 based on feedback and some community issues re: Tipping.
cc @Brave-Matt @kjozwiak

[kjozwiak]

@NejcZdovc moving priority to P1 based on feedback and some community issues re: Tipping.

Thanks @mandar-brave 👍

[NejcZdovc]

blocked on #1987

[LaurenWags]

Verified passed with

Brave	0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision	599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS	Mac OS X

• Verified retry logic happened per test plan for auto-contribution in Adds retries into contribution flow for rewards brave-core#890. Note, I had to restart browser to get retry to occur (this was noted in PR as might be necessary)
• Verified retry logic also worked for tips, but encountered BAT for tip withdrawn twice if internet connection lost after tipping #2297

Verification passed on:

Brave	0.57.8 Chromium: 71.0.3578.53 (Official Build) beta (64-bit)
Revision	599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS	Windows

• Verified retry logic happened per test plan for auto-contribution in Adds retries into contribution flow for rewards brave-core#890. Note, I had to restart browser to get retry to occur, just refresh rewards page will not help
  retry tipping after reconnect wifi/internet.

• Verified retry logic also worked for tips

Verification passed on

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta (64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Linux

• Verified retry logic happened per test plan for auto-contribution in Adds retries into contribution flow for rewards brave-core#890. Note, I had to restart browser to get retry to occur, just refresh rewards page will not help
  retry tipping after reconnect wifi/internet.

• Verified retry logic also worked for tips