-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds retries into contribution flow for rewards #890
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
contribution-retries
branch
3 times, most recently
from
November 12, 2018 14:23
a400210
to
0979f9d
Compare
tmancey
previously approved these changes
Nov 12, 2018
NejcZdovc
force-pushed
the
contribution-retries
branch
from
November 13, 2018 04:56
0979f9d
to
ad1c339
Compare
garrettr
approved these changes
Nov 13, 2018
NejcZdovc
added a commit
that referenced
this pull request
Nov 13, 2018
Adds retries into contribution flow for rewards
bbondy
reviewed
Nov 13, 2018
components/brave_rewards/resources/extension/brave_rewards/_locales/en_GB/messages.json
Show resolved
Hide resolved
srirambv
added
uplift-approved/0.57.x-Beta
and removed
uplift-request/0.57.x-Beta
labels
Nov 13, 2018
NejcZdovc
added a commit
that referenced
this pull request
Nov 13, 2018
Adds retries into contribution flow for rewards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#1483
Resolves brave/brave-browser#1481
Native implementation: brave-intl/bat-native-ledger#175
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
For easier debugging you can uncomment this sections https://github.com/brave-intl/bat-native-ledger/pull/175/files#diff-e91798fe1b25491970c7c977e168c25cR91
Reviewer Checklist:
Notes
Will be also adding flags for QA as wel brave/brave-browser#2102