-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale cover image height on tipping banner #2015
Labels
feature/rewards
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
NejcZdovc
added
feature/rewards
priority/P5
Not scheduled. Don't anticipate work on this any time soon.
labels
Nov 7, 2018
NejcZdovc
added
priority/P3
The next thing for us to work on. It'll ride the trains.
and removed
priority/P5
Not scheduled. Don't anticipate work on this any time soon.
labels
Feb 21, 2019
cg505
added a commit
to brave/brave-ui
that referenced
this issue
May 29, 2019
This fixes vertical clipping of the header image when the browser is very wide. Resolves brave/brave-browser#2015.
9 tasks
cg505
added a commit
to brave/brave-ui
that referenced
this issue
May 30, 2019
This fixes vertical clipping of the header image when the browser is very wide. Resolves brave/brave-browser#2015.
cg505
added a commit
to brave/brave-ui
that referenced
this issue
Jun 3, 2019
This fixes vertical clipping of the header image when the browser is very wide. Resolves brave/brave-browser#2015.
cg505
added a commit
to brave/brave-ui
that referenced
this issue
Jun 18, 2019
This fixes vertical clipping of the header image when the browser is very wide. Resolves brave/brave-browser#2015.
cg505
added a commit
to brave/brave-ui
that referenced
this issue
Jun 19, 2019
This fixes vertical clipping of the header image when the browser is very wide. See brave/brave-browser#2015.
cg505
added a commit
to brave/brave-ui
that referenced
this issue
Jun 29, 2019
This fixes vertical clipping of the header image when the browser is very wide. See brave/brave-browser#2015.
29 tasks
This was referenced Aug 22, 2019
Verified passed with
standard image at ~1500px - verified image height is 176 px. Verification passed on
standard image at ~1500px - verified image height is 176 px. Verification passed on
custom image at ~1000px |
NejcZdovc
pushed a commit
to brave/brave-core
that referenced
this issue
Sep 19, 2019
…r image in siteBanner This fixes vertical clipping of the header image when the browser is very wide. See brave/brave-browser#2015.
This was referenced Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/rewards
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
The cover image height on tipping banners is fixed at
176px
leading to the cover image getting chopped.Following discussion with @NejcZdovc and @jenn-rhim , it would be a good to fix the cover image rendering on the browser.
With a scaled height the banner could achieve something like
The solution would be dynamically calculating the height of the cover to
(176/900) * width
The text was updated successfully, but these errors were encountered: