Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale cover image height on tipping banner #2015

Closed
dlipeles opened this issue Nov 6, 2018 · 1 comment · Fixed by brave/brave-core#2566
Closed

Scale cover image height on tipping banner #2015

dlipeles opened this issue Nov 6, 2018 · 1 comment · Fixed by brave/brave-core#2566

Comments

@dlipeles
Copy link

dlipeles commented Nov 6, 2018

The cover image height on tipping banners is fixed at 176px leading to the cover image getting chopped.

Following discussion with @NejcZdovc and @jenn-rhim , it would be a good to fix the cover image rendering on the browser.

screen shot 2018-11-06 at 11 43 45 am

With a scaled height the banner could achieve something like

screen shot 2018-11-06 at 12 21 55 pm

The solution would be dynamically calculating the height of the cover to (176/900) * width

@NejcZdovc NejcZdovc added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 7, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Nov 13, 2018
@rossmoody rossmoody self-assigned this Jan 20, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Feb 21, 2019
@rossmoody rossmoody removed their assignment Apr 18, 2019
cg505 added a commit to brave/brave-ui that referenced this issue May 29, 2019
This fixes vertical clipping of the header image when the browser is
very wide.

Resolves brave/brave-browser#2015.
@cg505 cg505 self-assigned this May 30, 2019
cg505 added a commit to brave/brave-ui that referenced this issue May 30, 2019
This fixes vertical clipping of the header image when the browser is
very wide.

Resolves brave/brave-browser#2015.
cg505 added a commit to brave/brave-ui that referenced this issue Jun 3, 2019
This fixes vertical clipping of the header image when the browser is
very wide.

Resolves brave/brave-browser#2015.
@cg505 cg505 added this to the 0.68.x - Nightly milestone Jun 4, 2019
cg505 added a commit to brave/brave-ui that referenced this issue Jun 18, 2019
This fixes vertical clipping of the header image when the browser is
very wide.

Resolves brave/brave-browser#2015.
cg505 added a commit to brave/brave-ui that referenced this issue Jun 19, 2019
This fixes vertical clipping of the header image when the browser is
very wide.

See brave/brave-browser#2015.
cg505 added a commit to brave/brave-ui that referenced this issue Jun 29, 2019
This fixes vertical clipping of the header image when the browser is
very wide.

See brave/brave-browser#2015.
@NejcZdovc NejcZdovc removed this from the 0.68.x - Dev milestone Jul 2, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Sep 6, 2019

Verified passed with

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

custom image at ~1000px
Screen Shot 2019-09-06 at 2 56 35 PM

standard image at ~1500px - verified image height is 176 px.
Screen Shot 2019-09-06 at 2 57 43 PM

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

custom image at ~1000px
image

standard image at ~1500px - verified image height is 176 px.
image

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

custom image at ~1000px

image

NejcZdovc pushed a commit to brave/brave-core that referenced this issue Sep 19, 2019
…r image in siteBanner

This fixes vertical clipping of the header image when the browser is
very wide.

See brave/brave-browser#2015.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants