update brave-ui for tip site banner image fix

[cg505]

See brave/brave-ui#484.
Changes from brave-ui: brave/brave-ui@1fd91fa...0220a24

Resolves brave/brave-browser#2015

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message. (In Don't vertically clip creator header images in tip UI brave-ui#484.)
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Windows
  • macOS
  • Linux
• Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
  • Windows
  • macOS
  • Linux
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

See test plan in brave/brave-ui#484.

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[petemill]

Tested works great. Apart from the changes requested, I'm worried about a flash-of-change-of-height when the image loads after the dialog displays and then subsequently pushes the dialog taller. However, I would be happy to get this in to a build and see how serious the issue is in the real world. We could then either revert or fix in a number of different ways.

[cg505]

I'm not sure what causes the initial flash at the wrong size. If it's based on some provided height estimate, we can adjust that.

[petemill]

I'm not sure what causes the initial flash at the wrong size. If it's based on some provided height estimate, we can adjust that.

@cg505 I assume it's the difference between the non-loaded image and the loaded image, or the non-custom image and the custom image?

[petemill]

LGTM, let's check on any flashes of height when the dialog learns about the existence of a custom banner. If something is noticeable then we can follow-up.

[petemill]

Merging as previous build passed all checks. Most recent push was simply updating brave-ui after merge. https://staging.ci.brave.com/job/brave-core-build-pr/job/PR-2566/5/

[bsclifton]

Updated milestone to be master (0.69.x) since I didn't see this get uplifted