Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tab page overflow #5038

Closed
rossmoody opened this issue Jun 25, 2019 · 3 comments
Closed

New tab page overflow #5038

rossmoody opened this issue Jun 25, 2019 · 3 comments

Comments

@rossmoody
Copy link
Contributor

rossmoody commented Jun 25, 2019

Test plan

See #5038 (comment)

Description

New tab page is getting scrollbars from overflow around 920px -> 1120px widths. Should have it just be responsive without the scrollbars.

image

@imptrx
Copy link

imptrx commented Jun 27, 2019

Test Plan:

  1. Open New tabs page
  2. Slowly shrink window and see if horizontal/vertical scroll bars appear

Note: Beyond a certain size, shrinking will always produce vertical scroll bars since the page doesn't fit the elements

@imptrx imptrx added this to the 0.69.x - Nightly milestone Jun 27, 2019
@imptrx
Copy link

imptrx commented Jul 1, 2019

Closed by: brave/brave-core#2566 as it pulled in the fix from brave-ui.

@btlechowski
Copy link

btlechowski commented Aug 30, 2019

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Verified test plan from #5038 (comment)

Logged #5844

image
image
image

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Verified test plan from #5038 (comment)

Encountered #5844

image
image
image

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Screen Shot 2019-09-03 at 2 48 01 PM

Screen Shot 2019-09-03 at 2 47 27 PM

Screen Shot 2019-09-03 at 2 47 14 PM

tmancey pushed a commit that referenced this issue Apr 9, 2020
Updates TAP promotion copy (uplift to 1.7.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants