Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 98.0.4758.72 to Chromium 98.0.4758.74. #20741

Closed
mkarolin opened this issue Jan 27, 2022 · 6 comments · Fixed by brave/brave-core#12026
Closed

Upgrade from Chromium 98.0.4758.72 to Chromium 98.0.4758.74. #20741

mkarolin opened this issue Jan 27, 2022 · 6 comments · Fixed by brave/brave-core#12026

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/98.0.4758.72..98.0.4758.74?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

@LaurenWags
Copy link
Member

@brave/legacy_qa please ensure cases from #20726 (comment) have been covered on the appropriate platforms.

@kjozwiak
Copy link
Member

Looks like the remaining cases for Win x64 & Android ARM are the SKU cases. @StephenBass finished up Linux & macOS as per #20726 (comment) & #20726 (comment).

To do for this particular issue:

  • Win x64 & Android ARM - verify SKU cases + checking that the above made it into the latest RC like we usually do
  • Linux & macOS - simply checking to make sure the latest RC includes 98.0.4758.74

The above can be QA'd using 1.35.98 Chromium 98.0.4758.74 👍

@stephendonner
Copy link

stephendonner commented Jan 31, 2022

Verified PASSED using

Brave 1.35.98 Chromium: 98.0.4758.74 (Official Build) (x86_64)
Revision d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS macOS Version 11.6.1 (Build 20G224)

Screen Shot 2022-01-31 at 9 57 45 AM


Verification passed on

Brave 1.35.98 Chromium: 98.0.4758.74 (Official Build) (64-bit)
Revision d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS Ubuntu 18.04 LTS

image

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.35.98 Chromium: 98.0.4758.74 (Official Build) (64-bit)
-- | --
Revision | d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS | Windows 11 Version 21H2 (Build 22000.469)

image

Went through the SKU cases that @bsclifton mentioned via brave/brave-core#11985 (comment) as per the following:

SKU Test Case 1 - SKU functionality is disable on allow-list domains
1. Visit https://account.brave.software and enter basic auth credentials (reach out to @bsclifton for details)
2. Open dev tools (F12, etc) and go to `Console` tab
3. Paste in: `await window.chrome.braveSkus.refresh_order('0ee1e3ee-afc3-4f2f-b2a2-3d1e401e1530')` and hit enter. It should show
    ```
    Uncaught TypeError: Cannot read properties of undefined (reading 'refresh_order')
    at <anonymous>:1:31
    ```
4. Steps 1-3 can be repeated on https://account.brave.com or https://account.bravesoftware.com
https://account.brave.software https://account.brave.com https://account.bravesoftware.com
image image image
SKU Test Case 2 - SKU functionality is disabled on non-allowed domains
1. Visit any non-Brave website
2. Open dev tools (F12, etc) and go to `Console` tab
3. Paste in: `await window.chrome.braveSkus.refresh_order('0ee1e3ee-afc3-4f2f-b2a2-3d1e401e1530')` and hit enter. It should show
    ```
    Uncaught TypeError: Cannot read properties of undefined (reading 'refresh_order')
    at <anonymous>:1:31
    ```
https://videocardz.com https://www.amazon.ca https://store.steampowered.com
image image image

@kjozwiak
Copy link
Member

kjozwiak commented Feb 1, 2022

Labelling as QA/No in favour of #20814 which will be in the next RC.

@srirambv
Copy link
Contributor

srirambv commented Feb 1, 2022

Verification passed on Samsung Tab A with Android 10 running 1.35.98 x64 build

Verified SKU functionality works as expected
account.brave.com account.bravesoftware.com account.brave.software
image image image

Verification passed on Oppo Reno 5 with Android 11 running 1.35.98 x64 build

Verified SKU functionality works as expected
account.brave.com account.bravesoftware.com account.brave.software
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment