Brave sync show error in UI on sync-setup-error

[AlexeyBarabash]

Description

Error from sync-setup-error is displayed only in logs, need to make to show it in UI.

Examples of the situations when error is occurred:

1. No internet connection
2. Wrong code phrase
3. Empty code phrase
4. No device name (added here -- will be removed in 0.58.x)

Steps to Reproduce

1. Run Brave enabling Sync via brave --enable-brave-sync
2. Open page brave://bravesync/
3. Click I have an existing sync code

Case 1 - No internet connection

1. Open Brave devtools, go to network tab -> click the "offline" toggle
2. Click Set up Sync
3. Should show the appropriate alert message

Case 2 - Wrong code phrase

1. Enter wrong words noise elite faculty between enforce soul happy talk nut anxiety minute flower follow cradle act road hollow lazy unlock glove brush pepper buyer wrongword
2. Click Set up Sync
3. Should show the appropriate alert message

Case 3 - Empty Code Phrase

1. Leave the Code Phrase empty
2. Type something for device name
3. Click Set up Sync
4. Should show the appropriate alert message

Case 3 - No device name

1. Enter right words `borrow other exile curve inflict monster jacket piece shrug spider shock clip art describe task fancy odor such bargain legal embody sibling course labor
2. Type something for device name
3. Click Set up Sync
4. Should show the appropriate alert message

Actual result:

No error in UI. Only console log has message wrong code words

Expected result:

Error displayed in UI.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

0.59.1 Chromium: 71.0.3578.44 (Developer Build)

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  yes

[LaurenWags]

Reproduced with below build, except I do not see 'wrong code words' in terminal. There is no indication in the UI of what I did wrong.

Brave	0.57.6 Chromium: 71.0.3578.31 (Official Build) beta(64-bit)
Revision	c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS	Mac OS X

[cezaraugusto]

cc @bradleyrichter @rossmoody

[cezaraugusto]

heads-up I edited this issue description with states that the fixing PR address. The one that doesn't is referenced in #2262 and will be addressed separately.

[bbondy]

Pls no tracking open issues inside milestones. Moving out.
We use project boards per category now to triage importance.

[srirambv]

Verification passed on

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Linux

Invalid sync code( Wrong code phrase)

• Tried without entering sync code
• Tried with incorrect number of sync code words
• Tried with spelling mistakes
  

Device name is required

• Verified without entering a device name
  

No internet connection (With network disabled)

Verification passed on

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Windows

Invalid sync code( Wrong code phrase)

• Tried without entering sync code
• Tried with incorrect number of sync code words
• Tried with spelling mistakes

Without entering sync code

Incorrect number of sync code

Code word with spelling mistake

Entered Wrong Code

• Entered wrong code and got the below alert message to enter device name
  
• Verified after entering the device name, alert message is displayed as invalid code
  

Correct sync code, but network is disconnected

Verified passed with

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Mac OS X

No internet connection

Wrong code phrase

Empty code phrase

No device name

[khezsowavy]

Description

Error from sync-setup-error is displayed only in logs, need to make to show it in UI.

Examples of the situations when error is occurred:

1. No internet connection

2. Wrong code phrase

3. Empty code phrase

4. No device name (added here -- will be removed in 0.58.x)

Steps to Reproduce

1. Run Brave enabling Sync via brave --enable-brave-sync

2. Open page brave://bravesync/

3. Click I have an existing sync code

Case 1 - No internet connection

1. Open Brave devtools, go to network tab -> click the "offline" toggle

2. Click Set up Sync

3. Should show the appropriate alert message

Case 2 - Wrong code phrase

1. Enter wrong words noise elite faculty between enforce soul happy talk nut anxiety minute flower follow cradle act road hollow lazy unlock glove brush pepper buyer wrongword

2. Click Set up Sync

3. Should show the appropriate alert message

Case 3 - Empty Code Phrase

1. Leave the Code Phrase empty

2. Type something for device name

3. Click Set up Sync

4. Should show the appropriate alert message

Case 3 - No device name

1. Enter right words `borrow other exile curve inflict monster jacket piece shrug spider shock clip art describe task fancy odor such bargain legal embody sibling course labor

2. Type something for device name

3. Click Set up Sync

4. Should show the appropriate alert message

Actual result:

No error in UI. Only console log has message wrong code words

Expected result:

Error displayed in UI.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

0.59.1 Chromium: 71.0.3578.44 (Developer Build)

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?

yes

issue is unresolved