-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync warn modal needs refactoring #2128
Labels
dev-concern
feature/sync
priority/P5
Not scheduled. Don't anticipate work on this any time soon.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
Comments
srirambv
added
feature/sync
priority/P5
Not scheduled. Don't anticipate work on this any time soon.
dev-concern
labels
Nov 14, 2018
Assuming this will be addressed in the sync v2 ui? |
ya correct |
Also, it would be good to have this message for
Related issue: #2103 |
This was referenced Nov 23, 2018
Verification passed on
Verification passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev-concern
feature/sync
priority/P5
Not scheduled. Don't anticipate work on this any time soon.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Description
Sync warn modal needs refactoring
Steps to Reproduce
--enable-brave-sync
I have an existing Sync code
Setup Sync
without entering any code or device name, shows the warn message which is just plain text (see screenshot)Actual result:
Expected result:
Should show proper error message which is refactored
Reproduces how often:
Easy
Brave version (brave://version info)
Reproducible on current release:
Yes on beta build
Website problems only:
Additional Information
#2126 also needs a warning similar to this if a device name is mandatory
@rebron @bbondy @kjozwiak added to 1.x backlog as this is just a refactor which isn't priority but if needed please add it to 0.57.x milestone.
The text was updated successfully, but these errors were encountered: