-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow contributions to non-verified sites setting is not being respected #2111
Labels
bug
feature/rewards
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
rebron
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Nov 16, 2018
18 tasks
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Dec 7, 2018
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Dec 18, 2018
Verification passed on
Verification passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/rewards
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Description
If I uncheck the 'Allow contributions to non-verified sites' setting, non-verified sites are added to the table with 0% attention until a verified site is added. Then all percentage values get recalculated.
If 'Allow contributions to non-verified sites' is unchecked, non-verified sites should not be added to Auto-Contribute table.
Steps to Reproduce
Actual result:
Expected result:
If 'Allow contributions to non-verified sites' is unchecked, non-verified sites should not be added to the Auto-Contribute table. This is how this setting worked in Brave Payments.
Reproduces how often:
easily
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
cc @brave/legacy_qa to check on other platforms
The text was updated successfully, but these errors were encountered: