Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand and updates #212

Closed
25 tasks done
srirambv opened this issue May 22, 2018 · 7 comments
Closed
25 tasks done

Rebrand and updates #212

srirambv opened this issue May 22, 2018 · 7 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented May 22, 2018

URL's

  • Get help with Brave points to google support on about brave
  • Sign into Brave under bookmarks menu
    image
  • Help center in bookmarks points to Google support, should point to https://community.brave.com
    image
  • Webview crash Learn more points to Google support page . Should point to Brave wiki or https://community.brave.com
    image
  • Sign in on chrome://apps page
    image
  • Reset settings modal link to Google support page. Should be linked to Brave wiki or https://community.brave.com (Settings -> System -> Reset)
    image
  • Search engine URL points to Google support page.
    image
  • Privacy and security under advanced settings points to Google support page
    image
  • Access password from any device under advance settings links to https://passwords.google.com/ (Settings-> Advanced -> Passwords and Forms -> Manage password
    image
  • Help button on Manage password link to Google support page
    image
  • Get extensions points to Chrome webstore on chrome://extensions, Link/icon should be changed
  • Do not track info modal has link to Google support page
    image
  • Brave API keys notification upon launch. Learn more links to Google page. Either remove the notification or change the link
    image
  • chrome://extensions shows link to Google webstore this is on 2e9c470
    image
  • Advanced Font settings links to Google webstore page
    Settings -> Customize fonts -> Advanced Font setting
    image
  • Content settings info button links to Google support page Settings -> Content settings
    image

Icons

  • Brave icon for chrome pages and in chrome://settings/help

Settings

  • Google Cloud print option
  • Settings -> Accessibility - Points to Chrome Webstore
  • Google support link when an search result isn't shown (see sceenshot)
    image
  • User sign in button
    image
  • Themes links to opening Google webstore (Settings -> Appearance -> Themes)
    image
    - [ ] Remove Chrome person 1 from bookmark import modal
    image
  • Manage other people opens up a new user management window which contains Chrome icon needs to be replaced with Brave icon
    image
  • Remove Sign in to Brave is disabled by the administrator of this device. from people menu
    image
  • Context menu in text box shows option to Ask Google for suggestions
    image

cc: @bbondy

@simonhong
Copy link
Member

Also change uninstall survey url - GetUninstallSurveyUrl() in google_chrome_distribution.cc.

@srirambv
Copy link
Contributor Author

srirambv commented Jun 15, 2018

  • History -> Tabs from other devices asks for Google sign in
    image

@srirambv
Copy link
Contributor Author

srirambv commented Jun 15, 2018

Edit: After doing a clean build its working as expected

@yrliou I still the Brave API keys message on the release build(1c4f830) and on packaged build.

Search still points to Google support page
search

Privacy still points to Google Support page
privacy

Content settings info still points to Google support page
content

DNT still points to Google support page
dnt

@srirambv
Copy link
Contributor Author

srirambv commented Jun 17, 2018

  • Saved password notification shows Sign in to Chrome that needs to be reworded

image

  • Incorrect search result shows Google Chrome Help link. Just needs renaming it already links to community page.
    image

@srirambv
Copy link
Contributor Author

Windows 8.1 launches a window after install that says Chrome. Needs to be rebranded. Windows 8.1 specific
windows8-brave-core

@srirambv
Copy link
Contributor Author

srirambv commented Jun 24, 2018

  • Settings -> Content Setting -> PDF -> PDF Documents says Download PDF files instead of automatically opening them in Chrome
    image

@srirambv
Copy link
Contributor Author

srirambv commented Oct 16, 2018

Verification Passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux
  • Verified no Google signin on any settings page
  • Verified all help links points to community.brave.com (later to be replaced with specific support links)
  • Verified no Chromium icons shown anywhere
  • Verified no settings has the word Chrome or Chromium in it
  • Verified password/cc modal doesn't have Google signin
  • Verified spellcheck option is renamed to Brave but should have been removed (Ask Brave for suggestion needs to be removed #1623)

Verification Passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (32-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows
  • Verified no Google signin on any settings page
  • Verified all help links points to community.brave.com (later to be replaced with specific support links)
  • Verified no Chromium icons shown anywhere
  • Verified no settings has the word Chrome or Chromium in it
  • Verified password/cc modal doesn't have Google signin
  • Verified spellcheck option is renamed to Brave but should have been removed (Ask Brave for suggestion needs to be removed #1623)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants