Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a contract address auto-populates previously added custom token details #21337

Closed
srirambv opened this issue Feb 25, 2022 · 1 comment · Fixed by brave/brave-core#12447
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Adding a contract address auto-populates previously added custom token details

Steps to Reproduce

  1. Add a custom token for visible asset on Ropsten
  2. Close the custom visible asset dialog
  3. Copy a different token contract address to clipboard
  4. Add custom token and paste in the contract address from previous step, auto-populates the data for the first token added in step 1
  5. Copy wallet address and paste it in the contract address, auto-populates the previous token details from step 4

Note: closing the dialog after it auto-populates and trying to add again doesn't auto-populate it

Actual result:

Custom.Token.Auto-Populate.mp4

Expected result:

Should only auto-populate if the token is already in the visible list but not enabled

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.36.106 Chromium: 99.0.4844.45 (Official Build) (64-bit)
Revision edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @josheleonard

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 25, 2022
@Douglashdaniel Douglashdaniel self-assigned this Feb 28, 2022
@Douglashdaniel Douglashdaniel added this to the 1.38.x - Nightly milestone Mar 2, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@Uni-verse
Copy link
Contributor

Verified using

Brave	1.38.90 Chromium: 100.0.4896.79 (Official Build) beta (x86_64) 
Revision	8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS	macOS Version 12.3.1 (Build 21E258)
  • Adding a contract address does not auto-populate fields with previously added token details

avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
 - Added the ability to redirect an AMP page to its canonical non-AMP version. ([#20458](brave/brave-browser#20458))
 - Added "Select network" field in the Brave Wallet "Add custom asset" modal. ([#21656](brave/brave-browser#21656))
 - Added isBraveWallet property to window.ethereum. ([#21949](brave/brave-browser#21949))
 - Added the ability to copy Brave Wallet transaction hash from "Transactions" on the "Portfolio" page. ([#19886](brave/brave-browser#19886))
 - Added confirmation screen after transaction is approved for Brave Wallet. ([#21733](brave/brave-browser#21733))
 - Added bottom padding to the Brave Wallet swap container. ([#21340](brave/brave-browser#21340))
 - Added loading skeletons for various areas within Brave Wallet. ([#21339](brave/brave-browser#21339))
 - Implemented balance updater interval for Brave Wallet. ([#21304](brave/brave-browser#21304))
 - Updated design for Brave Shields. ([#18630](brave/brave-browser#18630))
 - Updated IPFS node to go-ipfs v0.12.0. ([#21219](brave/brave-browser#21219))
 - Updated adblocking to execute all cosmetic scriptlets even if one fails. ([#21932](brave/brave-browser#21932))
 - Updated wording on Brave Wallet backup reminder banner. ([#21312](brave/brave-browser#21312))
 - Updated Brave Wallet swap capability to prevent unnecessarily encountering "Too many decimal places" error. ([#21527](brave/brave-browser#21527))
 - Updated URL for Brave Wallet Ropsten Test Faucet network. ([#21240](brave/brave-browser#21240))
 - Updated Brave Wallet password field to be cleared when an incorrect password is entered. ([#21010](brave/brave-browser#21010))
 - Updated "Portfolio" page of Brave Wallet to return all EVM network tokens. ([#20854](brave/brave-browser#20854))
 - Updated UI to increase spacing between "Assets" and "Transactions" on "Accounts" subview page of Brave Wallet. ([#21532](brave/brave-browser#21532))
 - Updated link text color to blue for Brave Wallet onboarding screen. ([#20302](brave/brave-browser#20302))
 - Updated alignment of options available from the Brave Wallet "More" menu. ([#19680](brave/brave-browser#19680))
 - Renamed "Monthly Contributions" to "Monthly Tips" for Brave Rewards. ([#20564](brave/brave-browser#20564))
 - Removed redirect after adding an account to Brave Wallet from the portfolio asset details screen. ([#19138](brave/brave-browser#19138))
 - Removed referral code from P3A reports. ([#21460](brave/brave-browser#21460))
 - Fixed unexpected storage cleanup on site close when "Clear cookies and site data when you close all windows" is enabled under brave://settings/cookies. ([#22493](brave/brave-browser#22493))
 - Fixed unblocked cookie consent dialogs on some websites when the brave://flags/#brave-adblock-cookie-list-default is enabled. ([#22032](brave/brave-browser#22032))
 - Fixed inability to solve Brave Rewards CAPTCHA in certain cases. ([#22180](brave/brave-browser#22180))
 - Fixed inability to import MetaMask wallet to Brave Wallet. ([#22492](brave/brave-browser#22492))
 - Fixed failed second sign request (eth_signTypedData_v4) for Loopring.io L2 activation when using Brave Wallet. ([#22070](brave/brave-browser#22070))
 - Fixed data on "Portfolio" page of Brave Wallet not being properly displayed due to parsing error. ([#21941](brave/brave-browser#21941))
 - Fixed broken placeholder icons for ERC721 tokens on Brave Wallet "Account" page. ([#21549](brave/brave-browser#21549))
 - Fixed "JSON data is not expected" when trying to import a crypto wallet into Brave Wallet in certain cases. ([#19526](brave/brave-browser#19526))
 - Fixed Brave Wallet network selector list being partially blurred on page load. ([#21423](brave/brave-browser#21423))
 - Fixed Brave Wallet "Add Custom Asset" modal incorrectly being populated with previously added custom token details. ([#21337](brave/brave-browser#21337))
 - Fixed EIP-1559 gas oracle incorrectly firing on non-EIP-1559 networks for Brave Wallet. ([#21107](brave/brave-browser#21107))
 - Fixed Brave Wallet percentage selector remaining selected when input value was updated. ([#20315](brave/brave-browser#20315))
 - Fixed Speedreader icon incorrectly disappearing in certain cases. ([#18243](brave/brave-browser#18243))
 - Fixed inability to exit reader mode when Speedreader is disabled. ([#18242](brave/brave-browser#18242))
 - Upgraded Chromium to 101.0.4951.41. ([#22431](brave/brave-browser#22431)) ([Changelog for 101.0.4951.41](https://chromium.googlesource.com/chromium/src/+log/100.0.4896.127..101.0.4951.41?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants