Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 101.0.4951.34 to Chromium 101.0.4951.41 #22431

Closed
mkarolin opened this issue Apr 20, 2022 · 5 comments · Fixed by brave/brave-core#13096
Closed

Upgrade from Chromium 101.0.4951.34 to Chromium 101.0.4951.41 #22431

mkarolin opened this issue Apr 20, 2022 · 5 comments · Fixed by brave/brave-core#13096

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/101.0.4951.34..101.0.4951.41?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

@LaurenWags
Copy link
Member

@brave/legacy_qa please be sure to test the affected areas (from #21507 (comment)) for macOS, Linux, and Tablet.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 21, 2022

Verification Passed using

Brave 1.38.105 Chromium: 101.0.4951.41 (Official Build) (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS Windows 11 Version 21H2 (Build 22000.613)

Crpgrade101495141

@Uni-verse
Copy link
Contributor

Verified using

Brave	1.38.104 Chromium: 101.0.4951.41 (Official Build) (64-bit) 
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Android 12;

Devices:
Samsung Galaxy Tab S7 | Android 12
Samsung Galaxy S21 | Android 12

  • Confirmed version number, branding.
Mobile Tablet
Screen Shot 2022-04-22 at 9 05 21 AM screenshot-1650644247994

@btlechowski
Copy link

btlechowski commented Apr 22, 2022

Verification passed on

Brave 1.38.106 Chromium: 101.0.4951.41 (Official Build) (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS Ubuntu 18.04 LTS

image

Sync (general operation, device removing from sync chain)

synced bookmarks
image
removed device
image

Search engines show up correctly in the settings (fresh profile and on upgrade)

clean
image
upgrade
image

UI shows data correctly for: Shields

image
image
image

UI shows data correctly for: Ad block

image

UI shows data correctly for: Rewards page

image
image
image
image

UI shows data correctly for: Rewards internals

image

UI shows data correctly for: Tipping

image
image
image
custom tip
image
image

UI shows data correctly for: Welcome

image
image
image
image

UI shows data correctly for: IPFS

image
image
image

UI shows data correctly for: NTP

image
image

Tor internals

image
image
image

Webcompat reporter

image
image

Shields function correctly when changing shields settings

image
image
image

Settings UI: toggling these settings works as expected: Extensions > WebTorrent

image
image
image

Settings UI: toggling these settings works as expected: Extensions > Widevine

image
image
image
image

Settings UI: toggling these settings works as expected: Privacy and security > Allow privacy-preserving product analytics (P3A)

Install 1.37.x - CR100 and disable the P3A switch in brave://settings/privacy and upgrade the profile to 1.38.x CR101 and ensured P3A is in a disabled state after the upgrade
Restart the browser and ensured the switch state is retained

image

Settings UI: toggling these settings works as expected: Privacy and security > Automatically send daily usage ping to Brave

image
image
image
image

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 25, 2022
@stephendonner
Copy link

stephendonner commented Apr 25, 2022

Verification PASSED using

Brave 1.38.106 Chromium: 101.0.4951.41 (Official Build) (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 11.6.5 (Build 20G527)

Screen Shot 2022-04-25 at 11 55 45 PM

Sync (general operation, removing device from sync chain) - PASSED
example example example example
Screen Shot 2022-04-25 at 6 29 50 PM Image from iOS Screen Shot 2022-04-25 at 6 31 48 PM Image from iOS (1)
Search engines (new profile & upgrade) - PASSED

New profile

example example example
Screen Shot 2022-04-25 at 10 47 53 PM Screen Shot 2022-04-25 at 10 48 10 PM Screen Shot 2022-04-25 at 10 48 22 PM

Upgrade, customized w/Startpage

example example example example example
Screen Shot 2022-04-25 at 10 58 44 PM Screen Shot 2022-04-25 at 11 00 20 PM Screen Shot 2022-04-25 at 11 05 19 PM Screen Shot 2022-04-25 at 11 05 31 PM Screen Shot 2022-04-25 at 11 05 36 PM

UI shows correctly for:

Shields - PASSED
example example example
Screen Shot 2022-04-25 at 8 53 31 PM Screen Shot 2022-04-25 at 8 53 34 PM Screen Shot 2022-04-25 at 8 55 32 PM
Adblock - PASSED
example example example example example example
Screen Shot 2022-04-25 at 6 36 54 PM Screen Shot 2022-04-25 at 6 37 11 PM Screen Shot 2022-04-25 at 6 37 26 PM Screen Shot 2022-04-25 at 6 37 18 PM Screen Shot 2022-04-25 at 6 37 35 PM Screen Shot 2022-04-25 at 6 37 42 PM
Rewards page - PASSED
example example example example
Screen Shot 2022-04-25 at 6 43 06 PM Screen Shot 2022-04-25 at 10 19 26 PM Screen Shot 2022-04-25 at 10 19 35 PM Screen Shot 2022-04-25 at 10 19 48 PM
Rewards internals - PASSED
example example example example example
Screen Shot 2022-04-25 at 6 10 07 PM Screen Shot 2022-04-25 at 6 10 12 PM Screen Shot 2022-04-25 at 6 10 15 PM Screen Shot 2022-04-25 at 6 10 17 PM Screen Shot 2022-04-25 at 6 10 20 PM
Tipping - PASSED
example example example
Screen Shot 2022-04-25 at 6 07 09 PM Screen Shot 2022-04-25 at 6 07 53 PM Screen Shot 2022-04-25 at 6 08 00 PM
Welcome - PASSED
example example example
Screen Shot 2022-04-25 at 6 02 48 PM Screen Shot 2022-04-25 at 6 02 53 PM Screen Shot 2022-04-25 at 6 02 55 PM
IPFS - PASSED
example example example
Screen Shot 2022-04-25 at 10 34 44 PM Screen Shot 2022-04-25 at 10 27 54 PM Screen Shot 2022-04-25 at 10 34 54 PM
New Tab Page (NTP) - PASSED
example example example
Screen Shot 2022-04-25 at 5 42 27 PM Screen Shot 2022-04-25 at 5 55 04 PM Screen Shot 2022-04-25 at 6 02 58 PM
WebCompat - PASSED

Confirmed UI and submission works:

WebCompat reporter stats.brave.com
Screen Shot 2022-04-25 at 4 00 16 PM Screen Shot 2022-04-25 at 5 35 39 PM
Shields function correctly (changing Shields settings) - PASSED

TBD

Settings UI:

Extensions > WebTorrent - PASSED
example example example example
Screen Shot 2022-04-25 at 5 48 40 PM Screen Shot 2022-04-25 at 5 50 11 PM Screen Shot 2022-04-25 at 5 50 15 PM Screen Shot 2022-04-25 at 5 50 28 PM
Extensions > Widevine - PASSED
example example example
Screen Shot 2022-04-25 at 5 32 57 PM Screen Shot 2022-04-25 at 5 33 03 PM Screen Shot 2022-04-25 at 5 33 23 PM
Privacy & security > Allow privacy-preserving product analytics (P3A) - PASSED
example example example example
Screen Shot 2022-04-25 at 5 42 27 PM Screen Shot 2022-04-25 at 3 58 14 PM Screen Shot 2022-04-25 at 5 46 35 PM Screen Shot 2022-04-25 at 5 44 38 PM
Privacy & security > Automatically send daily usage ping to Brave - PASSED
example example example example
Screen Shot 2022-04-25 at 6 12 06 PM Screen Shot 2022-04-25 at 3 41 42 PM Screen Shot 2022-04-25 at 6 12 10 PM Screen Shot 2022-04-25 at 6 13 13 PM

@LaurenWags LaurenWags removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 26, 2022
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
 - Added the ability to redirect an AMP page to its canonical non-AMP version. ([#20458](brave/brave-browser#20458))
 - Added "Select network" field in the Brave Wallet "Add custom asset" modal. ([#21656](brave/brave-browser#21656))
 - Added isBraveWallet property to window.ethereum. ([#21949](brave/brave-browser#21949))
 - Added the ability to copy Brave Wallet transaction hash from "Transactions" on the "Portfolio" page. ([#19886](brave/brave-browser#19886))
 - Added confirmation screen after transaction is approved for Brave Wallet. ([#21733](brave/brave-browser#21733))
 - Added bottom padding to the Brave Wallet swap container. ([#21340](brave/brave-browser#21340))
 - Added loading skeletons for various areas within Brave Wallet. ([#21339](brave/brave-browser#21339))
 - Implemented balance updater interval for Brave Wallet. ([#21304](brave/brave-browser#21304))
 - Updated design for Brave Shields. ([#18630](brave/brave-browser#18630))
 - Updated IPFS node to go-ipfs v0.12.0. ([#21219](brave/brave-browser#21219))
 - Updated adblocking to execute all cosmetic scriptlets even if one fails. ([#21932](brave/brave-browser#21932))
 - Updated wording on Brave Wallet backup reminder banner. ([#21312](brave/brave-browser#21312))
 - Updated Brave Wallet swap capability to prevent unnecessarily encountering "Too many decimal places" error. ([#21527](brave/brave-browser#21527))
 - Updated URL for Brave Wallet Ropsten Test Faucet network. ([#21240](brave/brave-browser#21240))
 - Updated Brave Wallet password field to be cleared when an incorrect password is entered. ([#21010](brave/brave-browser#21010))
 - Updated "Portfolio" page of Brave Wallet to return all EVM network tokens. ([#20854](brave/brave-browser#20854))
 - Updated UI to increase spacing between "Assets" and "Transactions" on "Accounts" subview page of Brave Wallet. ([#21532](brave/brave-browser#21532))
 - Updated link text color to blue for Brave Wallet onboarding screen. ([#20302](brave/brave-browser#20302))
 - Updated alignment of options available from the Brave Wallet "More" menu. ([#19680](brave/brave-browser#19680))
 - Renamed "Monthly Contributions" to "Monthly Tips" for Brave Rewards. ([#20564](brave/brave-browser#20564))
 - Removed redirect after adding an account to Brave Wallet from the portfolio asset details screen. ([#19138](brave/brave-browser#19138))
 - Removed referral code from P3A reports. ([#21460](brave/brave-browser#21460))
 - Fixed unexpected storage cleanup on site close when "Clear cookies and site data when you close all windows" is enabled under brave://settings/cookies. ([#22493](brave/brave-browser#22493))
 - Fixed unblocked cookie consent dialogs on some websites when the brave://flags/#brave-adblock-cookie-list-default is enabled. ([#22032](brave/brave-browser#22032))
 - Fixed inability to solve Brave Rewards CAPTCHA in certain cases. ([#22180](brave/brave-browser#22180))
 - Fixed inability to import MetaMask wallet to Brave Wallet. ([#22492](brave/brave-browser#22492))
 - Fixed failed second sign request (eth_signTypedData_v4) for Loopring.io L2 activation when using Brave Wallet. ([#22070](brave/brave-browser#22070))
 - Fixed data on "Portfolio" page of Brave Wallet not being properly displayed due to parsing error. ([#21941](brave/brave-browser#21941))
 - Fixed broken placeholder icons for ERC721 tokens on Brave Wallet "Account" page. ([#21549](brave/brave-browser#21549))
 - Fixed "JSON data is not expected" when trying to import a crypto wallet into Brave Wallet in certain cases. ([#19526](brave/brave-browser#19526))
 - Fixed Brave Wallet network selector list being partially blurred on page load. ([#21423](brave/brave-browser#21423))
 - Fixed Brave Wallet "Add Custom Asset" modal incorrectly being populated with previously added custom token details. ([#21337](brave/brave-browser#21337))
 - Fixed EIP-1559 gas oracle incorrectly firing on non-EIP-1559 networks for Brave Wallet. ([#21107](brave/brave-browser#21107))
 - Fixed Brave Wallet percentage selector remaining selected when input value was updated. ([#20315](brave/brave-browser#20315))
 - Fixed Speedreader icon incorrectly disappearing in certain cases. ([#18243](brave/brave-browser#18243))
 - Fixed inability to exit reader mode when Speedreader is disabled. ([#18242](brave/brave-browser#18242))
 - Upgraded Chromium to 101.0.4951.41. ([#22431](brave/brave-browser#22431)) ([Changelog for 101.0.4951.41](https://chromium.googlesource.com/chromium/src/+log/100.0.4896.127..101.0.4951.41?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment