-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom Brave notification ads should be attached to the browser window #22203
Comments
Verification passed on
Issue still reproducible. Per our process logged #30508 Verification passed on
Verified test plan from the description |
The parameter name was changed to |
I will raise an issue to add the latest feature/param/values to a README.md you can access in the repo. |
Follow up to #19464.
On Windows the custom ad notification is not anchored to Brave Window so the z-ordering does not work, the ad stays on top.
Steps to Reproduce
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --brave-ads-staging --rewards=staging=true --variations-server-url=https://v --enable-features="CustomAdNotifications:should_attach_ad_notification_to_browser_window/true"
Actual result:
Notification ad is not anchored to the browser window, the ad stays on top
Expected result:
Notification ad is anchored to the browser window
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
cc @brave/qa-team @jsecretan @tmancey @aseren
The text was updated successfully, but these errors were encountered: