Custom ad notifications should be attached to the browser window

[tmancey]

Custom ad notifications should be attached to the browser window (z-order)

[aseren]

I was able to attach notification popup to browser window by setting parent member of views::Widget::InitParams structure here: https://github.com/brave/brave-core/blob/master/browser/ui/views/brave_ads/ad_notification_popup_widget.cc#L26

Passing browser window handler to AdNotificationPopupWidget::InitWidget function will be done separately in this issue: #17593. So change current issue to blocked until #17593 will be resolved.

[btlechowski]

In current state the feature is not usable on Linux nor on Windows

Verification passed on

Brave	1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision	8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS	Ubuntu 18.04 LTS

Used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --brave-ads-staging --rewards=staging=true --variations-server-url=https://v --enable-features="CustomAdNotifications:should_attached_ad_notification_to_browser_window/true"

Verified custom ad notification is attached to Brave Window:

Logged
#22205
#22206
#22216
#22218

Verification passed on

Brave	1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision	8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS	Windows 10 Version 21H2 (Build 19044.1586)

Used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --brave-ads-staging --rewards=staging=true --variations-server-url=https://v --enable-features="CustomAdNotifications:should_attached_ad_notification_to_browser_window/true"

Verified when minimizing and maximizing the browser window

The z-ordering does not work on Window, per our process logged a follow up:
#22203

[stephendonner]

Verified PASSED using

Brave	1.38.90 Chromium: 100.0.4896.79 (Official Build) beta (x86_64)
Revision	8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS	macOS Version 11.6.5 (Build 20G527)

Commandline used was:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --brave-ads-staging --rewards=staging=true --variations-server-url=https://v --enable-features="CustomAdNotifications:should_attached_ad_notification_to_browser_window/true"

Cases:

Confirmed ads were "attached" to the browser window
Confirmed I could drag to reposition the ads
Confirmed repositioned ads were still loosely "attached" to the browser window, and moved along with it

light, attached	light, repositioned	dark, attached	dark, repositioned

Confirmed ads were correctly restored (parented) after minimizing their attached window

ad/window before minimize	minimized	restored window

Encountered @btlechowski's already-filed #22203; couldn't cover the custom-ad notification with another app

example	example