Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom Brave Ad notifications should not disappear after minimizing and restoring the browser #22218

Closed
btlechowski opened this issue Apr 11, 2022 · 1 comment
Assignees
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.

Comments

@btlechowski
Copy link

Follow up to #19464.
custom ad notification disappears when attached to Brave Window after minimizing and restoring the browser

Steps to Reproduce

  1. Clean install
  2. Run Brave with: --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --brave-ads-staging --rewards=staging=true --variations-server-url=https://v --enable-features="CustomAdNotifications:should_attached_ad_notification_to_browser_window/true"
  3. Enable rewards and ads
  4. Trigger a notification ad
  5. Minimize the browser
  6. Restore the browser

Actual result:

custom ad notification disappears
There is no logs registered
19464_Ubuntu_minimized

Expected result:

custom ad notification re-appears with the browser window

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Ubuntu 18.04 LTS

cc @brave/qa-team @jsecretan @tmancey @aseren

@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Mar 1, 2023
@tmancey tmancey changed the title custom ad notification disappears after minimizing and restoring the browser Custom Brave Ad notification disappears after minimizing and restoring the browser Apr 13, 2023
@tmancey tmancey changed the title Custom Brave Ad notification disappears after minimizing and restoring the browser Fix custom Brave Ad notification disappears after minimizing and restoring the browser Apr 13, 2023
@tmancey tmancey changed the title Fix custom Brave Ad notification disappears after minimizing and restoring the browser Fix custom Brave Ad notifications should not disappear after minimizing and restoring the browser Apr 13, 2023
@tmancey tmancey added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Apr 20, 2023
@tmancey
Copy link
Contributor

tmancey commented Apr 20, 2023

Closed as resolved by #22203

@tmancey tmancey closed this as completed Apr 20, 2023
@kjozwiak kjozwiak removed bug priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/Desktop labels Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
Projects
None yet
Development

No branches or pull requests

4 participants