Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no notification after successful tip - follow up to 2114 #2275

Closed
LaurenWags opened this issue Nov 28, 2018 · 2 comments
Closed

no notification after successful tip - follow up to 2114 #2275

LaurenWags opened this issue Nov 28, 2018 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

Per test plan for #2114 (in PR brave/brave-core#896), there should be a notification after a tip is successful. No notification is being shown after successful tip.

Steps to Reproduce

  1. Clean profile on 0.57.8
  2. Enable Rewards
  3. Accept UGP grant.
  4. Tip a site (or YT channel)

Actual result:

No notification shown on BAT logo or when you view Brave Rewards Panel from logo.

Expected result:

Notification should be displayed and should show correct tip amount.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Reproduced by @btlechowski
cc @brave/legacy_qa for verification on other platforms

@LaurenWags
Copy link
Member Author

cc @rebron @NejcZdovc as the original issue 2114 was slated for 0.57.x

@mandar-brave mandar-brave added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 4, 2018
@NejcZdovc
Copy link
Contributor

this was changed and now we only show notification for auto contribute. Closing as there is no plan to add it for tip

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 19, 2019
@kjozwiak kjozwiak removed QA/Test-Plan-Specified QA/Yes bug feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 23, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 10, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants