Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution notifications not always showing #2114

Closed
NejcZdovc opened this issue Nov 13, 2018 · 2 comments · Fixed by brave/brave-core#896
Closed

Contribution notifications not always showing #2114

NejcZdovc opened this issue Nov 13, 2018 · 2 comments · Fixed by brave/brave-core#896

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Nov 13, 2018

Success notification is not working correctly.

  1. Add more detailed error notifications
  • auto contribute table is empty
  • not enough funds
@LaurenWags
Copy link
Member

LaurenWags commented Nov 28, 2018

@NejcZdovc Test Plan in PR (brave/brave-core#896) covers:

Per description of issue, with this issue should we also be testing the following?

  • Notification for successful auto-contribution
  • Notification for unsuccessful auto-contribution (when the auto-contribute table is empty)

cc @kjozwiak

@LaurenWags
Copy link
Member

LaurenWags commented Nov 29, 2018

Verified passed with

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Mac OS X
  • Verified notification for unsuccessful contribution (when there are not enough funds). Note, while a notification occurs, this notification does not match image in PR. Confirmed in slack that this is expected.
    screen shot 2018-11-29 at 2 01 57 pm

  • Verified notification for successful contribution
    screen shot 2018-11-29 at 2 01 41 pm

Logged these follow-up issues:

Verified passed with

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Windows 7
  • Verified notification for unsuccessful contribution
  • Verified notification for successful contribution

Issues:
#2275
#2294

Verified PASSED with Ubuntu 17.10

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Linux
  • Verified notification for unsuccessful contribution
  • Verified notification for successful contribution

Issues:
#2275
#2294

@bbondy bbondy changed the title Contribution notifications Contribution notifications not always showing Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment