-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves notifications for contribution #896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
contribution-notification
branch
from
November 13, 2018 11:17
c960219
to
2d89a3e
Compare
bbondy
reviewed
Nov 13, 2018
components/brave_rewards/resources/extension/brave_rewards/_locales/en_GB/messages.json
Outdated
Show resolved
Hide resolved
bbondy
reviewed
Nov 13, 2018
components/brave_rewards/resources/extension/brave_rewards/components/panel.tsx
Outdated
Show resolved
Hide resolved
bbondy
reviewed
Nov 13, 2018
components/brave_rewards/resources/extension/brave_rewards/components/panel.tsx
Outdated
Show resolved
Hide resolved
bbondy
previously requested changes
Nov 13, 2018
components/brave_rewards/resources/extension/brave_rewards/_locales/en_US/messages.json
Outdated
Show resolved
Hide resolved
NejcZdovc
force-pushed
the
contribution-notification
branch
from
November 13, 2018 18:24
2d89a3e
to
52ff8fb
Compare
18 tasks
bbondy
reviewed
Nov 13, 2018
components/brave_rewards/resources/extension/brave_rewards/components/panel.tsx
Show resolved
Hide resolved
NejcZdovc
force-pushed
the
contribution-notification
branch
3 times, most recently
from
November 14, 2018 08:51
4565ca0
to
862e1e6
Compare
NejcZdovc
force-pushed
the
contribution-notification
branch
from
November 14, 2018 10:39
862e1e6
to
fcff14c
Compare
NejcZdovc
force-pushed
the
contribution-notification
branch
from
November 14, 2018 11:40
fcff14c
to
b81edac
Compare
bbondy
previously approved these changes
Nov 14, 2018
NejcZdovc
force-pushed
the
contribution-notification
branch
from
November 14, 2018 15:41
b81edac
to
ceb2083
Compare
NejcZdovc
force-pushed
the
contribution-notification
branch
from
November 14, 2018 15:44
ceb2083
to
3975b57
Compare
bbondy
approved these changes
Nov 14, 2018
NejcZdovc
added a commit
that referenced
this pull request
Nov 14, 2018
Improves notifications for contribution
NejcZdovc
added a commit
that referenced
this pull request
Nov 14, 2018
Improves notifications for contribution
This was referenced Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#2114
Native implementation: brave-intl/bat-native-ledger#179
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
(start with reconcile interval flag)
Reviewer Checklist: