Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves notifications for contribution #896

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 13, 2018

Resolves brave/brave-browser#2114

Native implementation: brave-intl/bat-native-ledger#179

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • claim grant
  • do a tip
  • make sure that you see notification with correct amount

image

(start with reconcile interval flag)

  • enable rewards
  • claim grant
  • set monthly amount to 50
  • add site to ac table
  • make sure that you see notification telling you that there was an error because you don't have enough funds

image

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

bbondy
bbondy previously approved these changes Nov 14, 2018
@NejcZdovc NejcZdovc merged commit bc3ac42 into master Nov 14, 2018
@NejcZdovc NejcZdovc deleted the contribution-notification branch November 14, 2018 17:29
NejcZdovc added a commit that referenced this pull request Nov 14, 2018
Improves notifications for contribution
NejcZdovc added a commit that referenced this pull request Nov 14, 2018
Improves notifications for contribution
@NejcZdovc
Copy link
Contributor Author

master (0.59) bc3ac42
0.58.x e26f4ad
0.57.x 57f93ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribution notifications not always showing
2 participants