Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Widgets previews to remove Chrome defaults #22875

Closed
aguscruiz opened this issue May 16, 2022 · 2 comments · Fixed by brave/brave-core#15064
Closed

Update Widgets previews to remove Chrome defaults #22875

aguscruiz opened this issue May 16, 2022 · 2 comments · Fixed by brave/brave-core#15064
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include

Comments

@aguscruiz
Copy link

aguscruiz commented May 16, 2022

Description

We should update the previews for our widgets to include Brave Search, remove Google's example links.

Steps to reproduce

  1. Go to your home screen
  2. Tap on "Add widget"
  3. See Brave's widgets

Actual result

Screenshot_20220516-143024_One UI Home Screenshot_20220516-143030_One UI Home Screenshot_20220516-143033_One UI Home Screenshot_20220516-143040_One UI Home Screenshot_20220516-143059_One UI Home

Expected result

We should remove every chrome reference

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version: 11

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@aguscruiz aguscruiz added the OS/Android Fixes related to Android browser functionality label May 16, 2022
@lukemulks
Copy link

+1

Confirming that the Quick action search and Dino widgets contain the mismatch in static image.

Android, Samsung

The Quick action search widget = excellent, btw.
Screenshot_20220609-224658_One UI Home

@Uni-verse
Copy link
Contributor

Uni-verse commented Jan 11, 2023

Verified on Samsung Galaxy S21 using version:

Brave	1.47.169 Chromium: 109.0.5414.87 (Official Build) (64-bit) 
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	Android 12; Build/SP1A.210812.016

Spec: https://github.com/brave/internal/issues/942#issue-1426313155

Clean Profile

Widgets UI
Light Mode Dark Mode
screenshot-1673460225290 screenshot-1673460185398
Adding Quick Action Widget via menu (long press and drag)
Example Example
screenshot-1673455203594 screenshot-1673455218475
Adding Quick Action Widget via menu (Add button)
Example Example
screenshot-1673455203594 screenshot-1673455054178
Adding Widget via callout in url box
Example Example Example
screenshot-1673459702127 screenshot-1673454890270 screenshot-1673473027184
Adding Widget from home screen widget window
Example Example
screenshot-1673458531121 screenshot-1673460225290
Updating SE
  • Verified default SE displayed on the widget will update when user switching default SE in settings*

*encountered: #27749

Example Example
screenshot-1673473027184 screenshot-1673473053885
Using Quick Action Widget features (search, voice search, private tab)
Example Example Example Example
screenshot-1673473603078 screenshot-1673473610748 screenshot-1673473619275 screenshot-1673473645204
Removing Brave quick action widget
Example Example
screenshot-1673473745939 screenshot-1673473754258
Adding search widget from home screen
Example Example Example
screenshot-1673474025576 screenshot-1673474031502 screenshot-1673474117105
Using search feature
Example Example
screenshot-1673474117105 screenshot-1673474529621
Changing SE

encountered: #27749

Example Example
screenshot-1673474688971 screenshot-1673474117105
Adding Brave Bookmarks Widget using home screen widget window
Example Example Example (Folder Collapsed)
screenshot-1673474923918 screenshot-1673474930074 screenshot-1673475005975
Adding bookmarks bookmarks
Removing bookmarks
Example Example
screenshot-1673474986244 screenshot-1673474075183
Loading bookmarks from Widget
  • Verified webpage is loaded when tapping on the bookmarks in the bookmarks widget

Upgraded Profile

Existing widgets

encountered: #27757

1.46.x 1.47.x
screenshot-1673457309663 screenshot-1673457430012
Adding quick action widget on upgraded profile

Case:

  1. Install 1.46.x
  2. Launch Brave
  3. Upgrade to 1.47.x
  4. Add quick action widget from home screen
  5. Add quick action widget from brave menu
Example Example
screenshot-1673475853180 screenshot-1673475874770
Adding brave quick search widget

Case:

  1. Install 1.46.x
  2. Launch Brave
  3. Upgrade to 1.47.x
  4. Add brave search widget from home screen
  5. Add brave search widget from brave menu
search widget
Changing SE post upgrade

Case:

  1. Install 1.46.x
  2. Launch Brave
  3. Upgrade to 1.47.x
  4. Add brave search widget from home screen
  5. Change SE, relaunch app
Example Example
screenshot-1673476055553 screenshot-1673476201173
Adding bookmarks for existing widget on upgraded profile

Case:

  1. Install 1.46.x
  2. Launch Brave
  3. Add brave bookmarks widget from home screen
  4. Bookmark some websites under mobile bookmarks folder
  5. Upgrade to 1.47.x
  6. Bookmark some more websites after upgrade
1.46.x 1.47.x 1.47.x (Added new bookmark)
screenshot-1673476614703 screenshot-1673476692671 screenshot-1673476719579

@Uni-verse Uni-verse added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants