Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder text on brave widget doesn't update when changing default SE #27749

Closed
Uni-verse opened this issue Jan 11, 2023 · 3 comments · Fixed by brave/brave-core#16725
Closed

Comments

@Uni-verse
Copy link
Contributor

Description

Placeholder text on brave widget doesn't update when changing default SE

Steps to reproduce

  1. Install 1.47
  2. Open 3-dot menu -> settings -> Home screen widget
  3. Tap Add to add widget to device home screen
  4. Background brave app, confirm placeholder text on brave widget references current SE
  5. Open SE settings and change SE
  6. Background brave app again, check placeholder text on brave widget

Actual result

screenshot-1673455054178

Expected result

Brave widget should be re-added to home screen with updated SE selected for search

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung GS 21
  • Android version: 12

Brave version

1.47.168, Chromium 109.0.5414.87

Additional information

@Uni-verse
Copy link
Contributor Author

Uni-verse commented Jan 11, 2023

Update: User has to re-launch the app to update the quick action widget text

@kjozwiak
Copy link
Member

The above requires 1.47.178 or higher for 1.47.x verification 👍

@Uni-verse
Copy link
Contributor Author

Uni-verse commented Jan 23, 2023

Verified on Samsung Galaxy S21 using version:

Brave	1.47.181 Chromium: 109.0.5414.87 (Official Build) (64-bit) 
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	Android 13; Build/TP1A.220624.014

STR: #27749 (comment)

  • Verified changing default SE in search settings will update placeholder text in widget immediately
Example Example Example
screenshot-1674495908836 screenshot-1674495895735 screenshot-1674495863538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants