Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fix update search engine text on brave widget #16725

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

tapanmodh
Copy link
Contributor

Resolves brave/brave-browser#27749

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open app -> Open 3-dot menu -> settings -> Home screen widget
  2. Tap Add to add widget to device home screen
  3. Background brave app, confirm placeholder text on brave widget references current SE
  4. Open settings -> Search engines -> Standard Tab -> change SE
  5. Background brave app again, check placeholder text on brave widget

@tapanmodh tapanmodh added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 18, 2023
@tapanmodh tapanmodh added this to the 1.49.x - Nightly milestone Jan 18, 2023
@tapanmodh tapanmodh self-assigned this Jan 18, 2023
Copy link
Contributor

@wchen342 wchen342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapanmodh tapanmodh merged commit cab48e3 into master Jan 19, 2023
@tapanmodh tapanmodh deleted the fix_update_se_text_brave_widget_android branch January 19, 2023 19:58
brave-builds added a commit that referenced this pull request Jan 19, 2023
brave-builds added a commit that referenced this pull request Jan 19, 2023
@kjozwiak
Copy link
Member

Reproduced the original issue on Pixel 6 running Android 13 using the STR/Cases outlined via brave/brave-browser#27749 (comment) with the following build(s):

Brave | 1.49.41 Chromium: 109.0.5414.87 (Official Build) canary (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/TQ1A.230105.002
screen-20230120-003317.mp4

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.49.45 Chromium: 109.0.5414.87 (Official Build) canary (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/TQ1A.230105.002

Using the STR/Cases outlined via brave/brave-browser#27749 (comment), ensured that the string/text under the Home Widget is dynamically being updated when changing the default SE within Brave as per the following:

Example video of the the issue being fixed --> https://youtu.be/gZY2wASSj6Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholder text on brave widget doesn't update when changing default SE
4 participants