Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change brave://bravesync to brave://sync #2416

Closed
bbondy opened this issue Dec 8, 2018 · 1 comment · Fixed by brave/brave-core#1047
Closed

Change brave://bravesync to brave://sync #2416

bbondy opened this issue Dec 8, 2018 · 1 comment · Fixed by brave/brave-core#1047
Assignees
@bbondy
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.58.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Dec 8, 2018

brave://bravesync is harder to type, remember, doesn't look as good, and is repetitive.
@bbondy bbondy added this to the 1.x Backlog milestone Dec 8, 2018
@bbondy bbondy self-assigned this Dec 8, 2018
bbondy added a commit to brave/brave-core that referenced this issue Dec 8, 2018
@bbondy
Change brave://bravesync to brave://sync
152c0b1 
Fix brave/brave-browser#2416
@bbondy bbondy mentioned this issue Dec 8, 2018
Merged
18 tasks
@bbondy bbondy modified the milestones: 1.x Backlog, 0.58.x - Beta Dec 10, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 13, 2018 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.6 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows
  • Verified brave://sync redirects to Brave Sync page

image

  • Verified setting page displays brave://sync instead of brave://bravesync

image

  • Verified brave://bravesync doesn't redirects to Brave Sync page anymore.

Verification passed on

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

image
image

Verified passed with

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

screen shot 2018-12-13 at 11 07 02 am

screen shot 2018-12-13 at 11 06 50 am

@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Change brave://bravesync to brave://sync brave/brave-core
5 participants
@bbondy @kjozwiak @srirambv @LaurenWags @GeetaSarvadnya