Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change brave://bravesync to brave://sync #1047

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Change brave://bravesync to brave://sync #1047

merged 1 commit into from
Dec 10, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Dec 8, 2018

Fix brave/brave-browser#2416

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy requested a review from darkdh December 8, 2018 20:32
@kjozwiak
Copy link
Member

@bbondy approved uplift request to 0.58.x after deliberating with @rebron 👍Please ensure that all the correct labels are removed/added and the appropriate issue is moved to the correct milestone.

bbondy added a commit that referenced this pull request Dec 10, 2018
Change brave://bravesync to brave://sync
bbondy added a commit that referenced this pull request Dec 10, 2018
Change brave://bravesync to brave://sync
@bbondy
Copy link
Member Author

bbondy commented Dec 10, 2018

master: 0c2bcfc
0.59.x: adff287
0.58.x: c3b87fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change brave://bravesync to brave://sync
3 participants