Improve some P3A metrics #3931
Merged
Improve some P3A metrics #3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmancey @NejcZdovc PTAL |
NejcZdovc
reviewed
Dec 13, 2019
| @@ -50,6 +50,10 @@ void RecordAdsState(AdsP3AState state); | |||
| void UpdateAdsP3AOnPreferenceChange(PrefService* prefs, | |||
| const std::string& pref); | |||
|
|
|||
| // Records an initial metric state ("disabled" or "enabled") if it was not done | |||
| // before. Intended to be called if the user has already created a wallet. | |||
| void MaybeRecordInitialAdsP3AState(PrefService* local_state); | |||
There was a problem hiding this comment.
should this be prefs instead of local_state?
There was a problem hiding this comment.
nope, currently all metrics are intentionally stored in global state, so using it here is also fine. Atm we are ok with it
There was a problem hiding this comment.
Sorry, I should be more clear. I am talking about variable name. Because in h file you have MaybeRecordInitialAdsP3AState(PrefService* local_state), but in cc you have MaybeRecordInitialAdsP3AState(PrefService* prefs)
There was a problem hiding this comment.
ah, thanks, good catch
NejcZdovc
approved these changes
Dec 13, 2019
|
Thanks @tmancey @NejcZdovc |
bsclifton
force-pushed
the
ie_p3a_fix
branch
from
20aa0d2 to
b65aae2
Compare
bsclifton
added
CI/skip-android
|
Ran into GLIBC error on Linux |
bsclifton
force-pushed
the
ie_p3a_fix
branch
from
b8fb4c0 to
be5548a
Compare
|
Rebased - CI is running again for Linux 😄 GLIBC problem has been resolved (not related to this PR). Should be able to merge this soon and uplift to 1.2 |
added 4 commits
January 2, 2020 19:45
We want only two buckets instead of the Chromium default ones, so the existing histogram is transformed according to our needs.
We were recording a wrong value ("No wallet") even if the user already
had had a wallet in place. Now we try to properly record it and do it
only once with the help of an additional flag.
brave-builds
pushed a commit
that referenced
this pull request
Jan 3, 2020
This was referenced Jan 3, 2020
|
Verification passed with
metric
metric
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#6841
Fixes brave/brave-browser#7253
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.