Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve some P3A metrics (uplift to 1.4.x) #4301

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Improve some P3A metrics (uplift to 1.4.x) #4301

merged 1 commit into from
Jan 17, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 3, 2020 •
edited by iefremov
Loading

Uplift of #3931
Fixes brave/brave-browser#6841
Fixes brave/brave-browser#7253

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Jan 3, 2020
@brave-builds brave-builds added this to the 1.4.x - Dev milestone Jan 3, 2020
@bsclifton bsclifton requested review from a team and removed request for bbondy, tmancey, kjozwiak, bsclifton, rebron, NejcZdovc and srirambv January 6, 2020 17:47
@bsclifton
Copy link
Member

Similar to #4302:

  • only failure was on macOS test-install (not a blocker). CI looks good 👍
  • @iefremov have you had a chance to check this on Nightly since it was merged?

@iefremov
Copy link
Contributor

iefremov commented Jan 9, 2020

@iefremov have you had a chance to check this on Nightly since it was merged?

Yep! Sorry for the late reply

@kjozwiak
Copy link
Member

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/pr3931_ie_p3a_fix_1.4.x/1/execution/node/706/log/ failing.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jan 10, 2020
kjozwiak
kjozwiak approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. Both CI/Travis and CI/Jenkins passed after several restarts. @iefremov went through the PR on Nightly and confirmed that the fix was working as expected. @GeetaSarvadnya also ran through the PR on Nightly as per #3931 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 787fc55 into 1.4.x Jan 17, 2020
@kjozwiak kjozwiak deleted the pr3931_ie_p3a_fix_1.4.x branch January 17, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging this pull request may close these issues.
5 participants
@brave-builds @bsclifton @iefremov @kjozwiak @brave-browser-releases