You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have a Muon install which has a wallet with a non-zero balance
Launch Brave Core from the CLI with fresh profile
Use importer to import Brave (old). This should succeed (shows finish message)
Run import again, this time only picking Brave Payments
Because your wallet has a non-zero balance, the restore should fail
Error is logged to terminal
Import shows finish message, despite the second import failing
Description
When the upgrade happens from Muon to Brave Core, the importer is ran. If the importer encounters problems while importing Brave Payments, it cancels the import. This happens in the following scenarios:
unable to get an instance of rewards service
if wallet creation (creating the wallet to be imported into) fails
restore fails
backup of existing wallet fails (user already has a wallet, but with 0 balance)
getting wallet properties (ex: balance) returns an error
Instead of cancelling the import (which may roll back the bookmarks import or other imported items), we should continue with the import. The user can then restore their wallet manually by either:
trying to import Brave Payments only using Settings => Import (in Brave Core)
Launching Muon, exporting keywords, restoring keywords in Brave Core
The text was updated successfully, but these errors were encountered:
…ents, allow import to finish.
Errors are still logged, but import calls `FinishLedgerImport` instead of `Cancel` (which may abort progress made)
Fixesbrave/brave-browser#2421
Verified Test Plan in description
This error was logged in terminal [27863:775:1218/124309.314326:ERROR:brave_profile_writer.cc(221)] Brave Rewards wallet existed before import and has a balance of 65.3453; skipping Brave Payments import.
And the completion message still displayed
Used STR from OP, got log message [12884:16068:1219/011131.137:ERROR:brave_profile_writer.cc(221)] Brave Rewards wallet existed before import and has a balance of 24; skipping Brave Payments import.
Also used a different wallets in b-c (27 BAT) and b-l (24BAT) and got this log message: [12884:16068:1219/011315.591:ERROR:brave_profile_writer.cc(221)] Brave Rewards wallet existed before import and has a balance of 27; skipping Brave Payments import.
Used STR from OP, got log message [28280:28280:1220/015034.784410:ERROR:brave_profile_writer.cc(221)] Brave Rewards wallet existed before import and has a balance of 22; skipping Brave Payments import.
Test plan
Brave (old)
. This should succeed (shows finish message)Brave Payments
Description
When the upgrade happens from Muon to Brave Core, the importer is ran. If the importer encounters problems while importing Brave Payments, it cancels the import. This happens in the following scenarios:
Instead of cancelling the import (which may roll back the bookmarks import or other imported items), we should continue with the import. The user can then restore their wallet manually by either:
The text was updated successfully, but these errors were encountered: