-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import default search engine #1064
Conversation
…ents, allow import to finish. Errors are still logged, but import calls `FinishLedgerImport` instead of `Cancel` (which may abort progress made) Fixes brave/brave-browser#2421
Reduced scope of this PR, removed WIP label. Originally, I was going to put multiple fixes in here, but I think just these two are a great start. I added a test plan and ran into issues when manually testing it. Basically, the private tab settings didn't import properly. Looking at this now... |
OK private windows now properly respect the DDG true/false value I found a problem with Tor windows that I think is outside of the scope of this change. This PR will properly set |
lgtm, please clean up commits then I will approve |
- default search engine - use DDG/Qwant for private tabs - use DDG/Qwant for Tor tabs Fixes brave/brave-browser#2415 NOTE: if private tabs in tor is not set, TorWindowSearchEngineProviderService::GetInitialSearchEngineProvider will properly set the default
d3d4a41
to
d2e8388
Compare
@darkdh commits squashed! 😄👌 |
@bsclifton uplift request to |
Import default search engine
Import default search engine
Import default search engine
0.58.x broke after the above cherry-pick; fixed with #1090 |
Fixes brave/brave-browser#2421
Fixes brave/brave-browser#2415
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Bing
Use DuckDuckGo by default for search in Private Tabs
to trueUse DuckDuckGo by default for search in Private Tabs with Tor
to falseBrave (old)
from the drop down and import (doesn't matter which items you pick)Bing
Bing
Search with DuckDuckGo
is checkedBing
Reviewer Checklist: