Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Bridge to Aurora button #24377

Closed
jamesmudgett opened this issue Aug 2, 2022 · 3 comments · Fixed by brave/brave-core#14452
Closed

Implement Bridge to Aurora button #24377

jamesmudgett opened this issue Aug 2, 2022 · 3 comments · Fixed by brave/brave-core#14452
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.43.x - Release

Comments

@jamesmudgett
Copy link

jamesmudgett commented Aug 2, 2022 •
edited
Loading

From supported assets detail screen (on Aurora... NEAR) we will want to add a quick link to bridge. See supported assets (note all in the image below should include the bridge button)

Image

Example button placement

Image

Example modal for first click... subsequent clicks on bridge will not show the modal.

Image

(clicking Open... should launch a new tab to rainbowbridge.app)
@jamesmudgett jamesmudgett added feature/web3/wallet Integrating Ethereum+ wallet support priority/P3 The next thing for us to work on. It'll ride the trains. front-end-change This task is a front end task and doesn't need any C++ changes labels Aug 2, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Aug 2, 2022
@jamesmudgett
Copy link
Author

@rmcfadden3 please review and provide new copy for the modal.

@jamesmudgett
Copy link
Author

Learn more link https://ethereum.org/en/bridges/#bridge-risk

@muliswilliam muliswilliam moved this from Backlog to In Progress in Web3 Aug 3, 2022
@muliswilliam muliswilliam mentioned this issue Aug 3, 2022
Merged
25 tasks
@muliswilliam muliswilliam moved this from In Progress to In Review in Web3 Aug 4, 2022
@jamesmudgett jamesmudgett mentioned this issue Aug 4, 2022
Closed
Repository owner moved this from In Review to Done in Web3 Aug 4, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 4, 2022
@jamesmudgett jamesmudgett mentioned this issue Aug 4, 2022
Closed
@muliswilliam muliswilliam mentioned this issue Aug 5, 2022
Merged
7 tasks
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Linux
  • Verified steps from and as part of #24695 (comment)
  • Verified for supported asset, there is a button Bridge to Aurora on the asset details screen
  • Verified clicking on the button shows a modal about bridging details
  • Verified Learn more opens a new tab page and loads https://ethereum.org/en/bridges/#bridge-risk
  • Verified the modal is shown only once for the first time. Subsequent attempts doesn't show the modal
  • Encountered #24248

Verification passed on

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from and as part of #24695 (comment)
  • Verified for supported asset, there is a button Bridge to Aurora on the asset details screen
  • Verified clicking on the button shows a modal about bridging details
  • Verified Learn more opens a new tab page and loads https://ethereum.org/en/bridges/#bridge-risk
  • Verified the modal is shown only once for the first time. Subsequent attempts doesn't show the modal
  • Encountered #24248

Verification passed on

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (arm64)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from and as part of #24695 (comment)
  • Verified for supported asset, there is a button Bridge to Aurora on the asset details screen
  • Verified clicking on the button shows a modal about bridging details
  • Verified Learn more opens a new tab page and loads https://ethereum.org/en/bridges/#bridge-risk
  • Verified the modal is shown only once for the first time. Subsequent attempts doesn't show the modal
  • Encountered #24248

This was referenced Aug 31, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): implement bridge to aurora button brave/brave-core
4 participants
@jamesmudgett @srirambv @brave-builds @muliswilliam