Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): implement bridge to aurora button #14452

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

muliswilliam
Copy link
Contributor

Resolves brave/brave-browser#24377

Submitter Checklist:

  • I confirm that no security/privacy review is not needed
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Click on an asset in portfolio list for example Ethereum
  2. On the asset details page, if the asset support aurora bridging, you will see a button with the text Bridge to Aurora
  3. Click on the button, a modal should appear with bridging details.
  4. Click on Open rainbowbridge.app. A new tab should open and load https://rainbowbridge.app
Bridge.to.Aurora.mov

@muliswilliam muliswilliam requested a review from a team as a code owner August 3, 2022 16:45
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Aug 3, 2022
@muliswilliam muliswilliam changed the title feat: implement bridge to aurora button feat(wallet): implement bridge to aurora button Aug 3, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam force-pushed the feat-implement-bridge-to-aurora branch from c5892d3 to 9e6a282 Compare August 4, 2022 09:06
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam merged commit e559c30 into master Aug 4, 2022
@muliswilliam muliswilliam deleted the feat-implement-bridge-to-aurora branch August 4, 2022 19:25
@muliswilliam muliswilliam restored the feat-implement-bridge-to-aurora branch August 4, 2022 19:25
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 4, 2022
@muliswilliam muliswilliam deleted the feat-implement-bridge-to-aurora branch August 4, 2022 19:28
muliswilliam added a commit that referenced this pull request Aug 5, 2022
* feat: implement bridge to aurora button

* feedback: Add rel="noopener noreferrer" to link

* feedback: separate opening and closing modal functions

* chore: move openRainbowAppClick up and add openRainbowAppClick to deps list
@srirambv
Copy link
Contributor

srirambv commented Aug 8, 2022

Verification passed on

Brave 1.44.26 Chromium: 104.0.5112.81 (Official Build) nightly (64-bit)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from PR
  • Verified for supported asset, there is a button Bridge to Aurora on the asset details screen
  • Verified clicking on the button shows a modal about bridging details
  • Verified Learn more opens a new tab page and loads https://ethereum.org/en/bridges/#bridge-risk
  • Verified the modal is shown only once for the first time. Subsequent attempts doesn't show the modal
14452.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Bridge to Aurora button
4 participants