-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): implement bridge to aurora button #14452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Storybook has been deployed to preview UI for the latest push |
josheleonard
suggested changes
Aug 4, 2022
..._wallet_ui/components/desktop/popup-modals/bridge-to-aurora-modal/bridge-to-aurora-modal.tsx
Show resolved
Hide resolved
components/brave_wallet_ui/components/desktop/views/portfolio/portfolio-asset.tsx
Outdated
Show resolved
Hide resolved
c5892d3
to
9e6a282
Compare
A Storybook has been deployed to preview UI for the latest push |
josheleonard
suggested changes
Aug 4, 2022
components/brave_wallet_ui/components/desktop/views/portfolio/portfolio-asset.tsx
Show resolved
Hide resolved
josheleonard
approved these changes
Aug 4, 2022
A Storybook has been deployed to preview UI for the latest push |
muliswilliam
added a commit
that referenced
this pull request
Aug 5, 2022
* feat: implement bridge to aurora button * feedback: Add rel="noopener noreferrer" to link * feedback: separate opening and closing modal functions * chore: move openRainbowAppClick up and add openRainbowAppClick to deps list
7 tasks
Verification passed on
14452.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#24377
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Bridge to Aurora
Open rainbowbridge.app
. A new tab should open and loadhttps://rainbowbridge.app
Bridge.to.Aurora.mov