Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): Implement bridge to aurora button (uplift to 1.43.x) #14485

Merged
merged 1 commit into from
Aug 8, 2022
Merged

feat(wallet): Implement bridge to aurora button (uplift to 1.43.x) #14485

merged 1 commit into from
Aug 8, 2022

Conversation

muliswilliam
Copy link
Contributor

Uplift of #14452
Resolves brave/brave-browser#24377

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@muliswilliam
feat(wallet): implement bridge to aurora button (#14452)
57400e1 
* feat: implement bridge to aurora button

* feedback: Add rel="noopener noreferrer" to link

* feedback: separate opening and closing modal functions

* chore: move openRainbowAppClick up and add openRainbowAppClick to deps list
@muliswilliam muliswilliam requested a review from a team as a code owner August 5, 2022 09:02
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Aug 5, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

srirambv
srirambv approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.43.x is approved on behalf of @brave/uplift-approvers 👍🏻 Per process, QA has verified this via #14452 (comment)

@srirambv srirambv merged commit 698a4b1 into 1.43.x Aug 8, 2022
@srirambv srirambv deleted the feat-implement-bridge-to-aurora_1.43.x branch August 8, 2022 12:55
@github-actions github-actions bot added this to the 1.43.x - Beta milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srirambv srirambv srirambv approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@muliswilliam @brave-builds @srirambv