Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show IPFS button and do DNSLink redirects when IPFS Resolution method is setted up as ASK #25406

Closed
cypt4 opened this issue Sep 14, 2022 · 2 comments · Fixed by brave/brave-core#15263
Assignees
Labels
feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@cypt4
Copy link

cypt4 commented Sep 14, 2022

image

Currently this features are available only if IPFS resolution method is selected as GATEWAY or LOCAL.

Steps:

  1. Set IPFS resolution method to ASK
    image
  2. Set DNSLink autoredirect
    image
  3. Load https://en.wikipedia-on-ipfs.org

Actual result:
https version of the site is loaded

Expected result:
redirect to ipns://en.wikipedia-on-ipfs.org

@stephendonner
Copy link

Mind breaking this down into discrete steps, with expected and actual results, @cypt4 ? Thanks!

@jamesmudgett jamesmudgett moved this to Backlog in Web3 Sep 16, 2022
cypt4 added a commit to brave/brave-core that referenced this issue Sep 28, 2022
Repository owner moved this from Backlog to Done in Web3 Oct 3, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 3, 2022
@stephendonner
Copy link

stephendonner commented Oct 19, 2022

Verification PASSED using

Brave 1.46.68 Chromium: 107.0.5304.36 (Official Build) nightly (x86_64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 13.0 (Build 22A379)

Steps:

  1. installed 1.46.68
  2. launched Brave
  3. opened brave://settings/ipfs
  4. ensured Method to resolve IPFS resources is defaulted to Ask
  5. toggled Automatically redirect to IPFS pages via DNSLink when possible
  6. loaded https://en.wikipedia-on-ipfs.org/
  7. examined the resulting URL
    8a. clicked on Use a Brave local IPFS node
    8b. clicked on Use a public gateway
  8. ensured the content loaded over both types

Confirmed I could load ipns://en.wikipedia-on-ipfs.org over both local-node and public-gateway IPFS-delivery methods, and confirmed I got an IPFS badge when loading ipns://en.wikipedia-on-ipfs.org via public gateway

example example example example example example
Screenshot 2022-10-18 at 10 40 53 PM Screenshot 2022-10-18 at 10 41 56 PM Screenshot 2022-10-18 at 10 42 12 PM Screenshot 2022-10-18 at 10 42 19 PM Screenshot 2022-10-18 at 10 46 31 PM Screenshot 2022-10-18 at 10 46 34 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants